Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move rendering of Notes to dedicated layer #52

Open
wtimme opened this issue Feb 7, 2020 · 1 comment
Open

Move rendering of Notes to dedicated layer #52

wtimme opened this issue Feb 7, 2020 · 1 comment
Labels
refactoring Changes that improve the code quality

Comments

@wtimme
Copy link
Owner

wtimme commented Feb 7, 2020

User Story

As a developer, I want the fetching and rendering of the notes to be moved out of MapView, so that MapView has less responsibilities

Acceptance Criterias

  • The code for fetching the notes is moved to dedicated file(s)

Unhappy Cases

If these changes were not merged back to (bryceco/GoMap), the chances of merge conflicts increase.

@bryceco, is there anything I can do to increaes the chance that this will get merged also to your main repository?

Additional context

This is some preparation for #28. When we use protocols, we might be able to display quests the same way.

@bryceco
Copy link
Contributor

bryceco commented Apr 14, 2020

I’m fine with a change like this as long as it doesn’t change the existing behavior. I suspect it’s going to cause issues similar to #62, but if that is addressed I’ll accept the pull.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Changes that improve the code quality
Projects
None yet
Development

No branches or pull requests

2 participants