Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Characters inherent to other languages are dropped in change password authorisation header in myaccount app #20957

Closed
Tiffany-silva opened this issue Aug 21, 2024 · 2 comments
Milestone

Comments

@Tiffany-silva
Copy link

Describe the issue:

Certain special characters in passwords are being dropped when attempting to change the password using the MyAccount app. These characters which are usually specific to other languages, such as French or Greek (e.g., ç, æ, ô, £) included in the password during the password change function within the MyAccount app are dropped.

The issue arises because SCIM2 Patch request fails due to the authorisation header, which includes an encoded username and password, not retaining these special characters [1]. As a result, the user is shown the following error message:

Change password error
The current password you entered appears to be invalid. Please try again

[1] https://github.com/wso2/identity-apps/blob/master/apps/myaccount/src/api/change-password.ts#L50

How to reproduce:

  1. Register a user with a password consisting of unique characters found in other languages. For example: Testç123.
  2. Login to myaccount with the password.
  3. Update the password providing the current password.
  4. Password update fails with an invalid password error.

Expected behavior:
These characters should be correctly encoded and included in the authorisation header.

Environment information:

  • Product Version: IS 6.1.0
@ImalshaG
Copy link
Contributor

@Yasasr1 Are we good to close this issue?

@Yasasr1
Copy link
Contributor

Yasasr1 commented Oct 11, 2024

Fix is done with the following pr hence closing the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

4 participants