Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace the deprecated eslint-loader with eslint-webpack-plugin in Identity Apps #10009

Closed
brionmario opened this issue Oct 22, 2020 · 1 comment · Fixed by wso2/identity-apps#1924

Comments

@brionmario
Copy link
Member

brionmario commented Oct 22, 2020

Is your suggestion related to an experience ? Please describe.
eslint-loader was deprecated in favor of eslint-webpack-plugin (see https://github.com/webpack-contrib/eslint-loader).
Some advantages over eslint-loader include the reuse of the ESLint cache and improved lint performance (see https://github.com/webpack-contrib/eslint-webpack-plugin#about-plugin).

Describe the improvement
Replace the deprecated eslint-loader with eslint-webpack-plugin.

Additional context
Tried to migrate but there seems to be few issues with the new eslint-webpack-plugin.

  1. Recompile time significantly increased when migrated.(WDS significant increase in recompile time after migrating from eslint-loader webpack-contrib/eslint-webpack-plugin#20)
    • Used the lintDirtyModulesOnly as suggested but that caused errors to not being recognised.
  2. File names and path are not shown properly which makes it hard to figure out which file has the errors. A custom formatter has to be written to overcome the issue. (Replace deprecated eslint-loader by eslint-webpack-plugin facebook/create-react-app#9751 (comment))

Issues to keep an eye out for:

NOTE: Only do the migration when the plugin is stable.

@brionmario
Copy link
Member Author

Fixed with wso2/identity-apps#1924

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant