Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(react): fix doc issues #307

Merged
merged 2 commits into from
Nov 6, 2024
Merged

fix(react): fix doc issues #307

merged 2 commits into from
Nov 6, 2024

Conversation

brionmario
Copy link
Member

@brionmario brionmario commented Nov 6, 2024 •
edited
Loading

Purpose

  1. Fix broken images in the Storybook

  2. Fix the dark mode of the Multi-Brand design system sample which had a invalid teal color as the primary.

    Screenshot 2024-11-06 at 12 49 30

Related Issues

Related PRs

  • N/A

Checklist

  • Figma Board Updated. (Mandatory for Icon and Component PRs. If you don't have access, please ask the core team to update it.)
  • UX/UI review done on the final implementation.
  • Story provided. (Add screenshots)
  • Manual test round performed and verified.
  • Unit tests provided. (Add links if there are any)
  • Documentation provided. (Add links if there are any)

Security checks

@brionmario brionmario closed this Nov 6, 2024
@brionmario brionmario reopened this Nov 6, 2024
@brionmario brionmario merged commit 482894a into wso2:main Nov 6, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NipuniBhagya NipuniBhagya NipuniBhagya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Docs] Broken Images & Inconsistencies in the Multi-Brand design system sample
2 participants
@brionmario @NipuniBhagya