Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI fails due to node-sass incompatibility with Node.js v22.x #304

Open
15 tasks
JayaShakthi97 opened this issue Nov 5, 2024 · 2 comments
Open
15 tasks

CI fails due to node-sass incompatibility with Node.js v22.x #304

JayaShakthi97 opened this issue Nov 5, 2024 · 2 comments
Assignees
Labels
bug Something isn't working ci Continuous integration related issues.

Comments

@JayaShakthi97
Copy link
Contributor

Describe the issue:
The CI pipeline is failing due to incompatibility between the latest LTS version of Node.js (v22.x) and the version of node-sass currently in use (v8.x). According to the node-sass Node Version Support Policy, [email protected] is not compatible with Node.js v22, resulting in failures during dependency installation.

image

How to reproduce:

Expected behavior:

  • pr-builder to run without any issues.

Additional context :

  • Affected Package:
    • @oxygen-ui/logger
    • @oxygen-ui/primitives
    • @oxygen-ui/react
    • @oxygen-ui/react-icons
  • Library Version: [e.g., 1.10.0, 2.0.0-alpha]
  • OS:
    • Windows
    • Linux
    • Mac
    • Other
  • Browser:
    • Google Chrome
    • Firefox
    • Safari
    • Microsoft Edge
    • Brave
    • Opera
    • Other

Optional Fields

Related issues:

Suggested labels:

@JayaShakthi97 JayaShakthi97 added bug Something isn't working ci Continuous integration related issues. labels Nov 5, 2024
@JayaShakthi97 JayaShakthi97 self-assigned this Nov 5, 2024
@JayaShakthi97
Copy link
Contributor Author

JayaShakthi97 commented Nov 5, 2024

Proposed Solutions

  1. Upgrade node-sass (if possible): Check if a newer version of node-sass (if available) supports Node.js v22. Update to that version if feasible.
  2. Switch to sass (Dart Sass): Consider replacing node-sass with sass (Dart Sass), which is compatible with all Node.js versions and does not require native bindings.
  3. Pin Node.js Version: Temporarily pin the Node.js version in CI to an older LTS version (e.g., Node v18) that is compatible with [email protected]. This will unblock the CI pipeline until an alternative solution is implemented.

@JayaShakthi97
Copy link
Contributor Author

Stick the node version in CI

@JayaShakthi97 JayaShakthi97 changed the title CI Fails Due to node-sass Incompatibility with Node.js v22.x CI fails due to node-sass incompatibility with Node.js v22.x Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ci Continuous integration related issues.
Projects
None yet
Development

No branches or pull requests

1 participant