From e127d7800835ac006075bd96616f28bc12c5c3fb Mon Sep 17 00:00:00 2001
From: Jonathan Leitschuh <Jonathan.Leitschuh@gmail.com>
Date: Sat, 16 Dec 2023 06:17:16 +0000
Subject: [PATCH] vuln-fix: Use HTTPS instead of HTTP to resolve deps
 CVE-2021-26291

This fixes a security vulnerability in this project where the `pom.xml`
files were configuring Maven to resolve dependencies over HTTP instead of
HTTPS.

Weakness: CWE-829: Inclusion of Functionality from Untrusted Control Sphere
Severity: High
CVSS: 8.1
Detection: CodeQL & OpenRewrite (https://app.moderne.io/recipes/org.openrewrite.maven.security.UseHttpsForRepositories)

Reported-by: Jonathan Leitschuh <Jonathan.Leitschuh@gmail.com>
Signed-off-by: Jonathan Leitschuh <Jonathan.Leitschuh@gmail.com>

Bug-tracker: https://github.com/JLLeitschuh/security-research/issues/8
Detection: CodeQL (https://codeql.github.com/codeql-query-help/java/java-maven-non-https-url/) & OpenRewrite (https://app.moderne.io/recipes/org.openrewrite.maven.security.UseHttpsForRepositories)

Reported-by: Jonathan Leitschuh <Jonathan.Leitschuh@gmail.com>
Signed-off-by: Jonathan Leitschuh <Jonathan.Leitschuh@gmail.com>

Bug-tracker: https://github.com/JLLeitschuh/security-research/issues/8


Use this link to re-run the recipe: https://app.moderne.io/recipes/builder/IfHkrYfxx?organizationId=QWxsIEdpdEh1Yg%3D%3D

Co-authored-by: Moderne <team@moderne.io>
---
 batik/1.9.1.wso2v1/pom.xml       | 2 +-
 bsf/3.0.0.wso2v4/pom.xml         | 2 +-
 commons-io/2.11.0.wso2v1/pom.xml | 6 +++---
 openjpa-all/3.0.0.wso2v1/pom.xml | 6 +++---
 ua-parser/1.5.2.wso2v1/pom.xml   | 2 +-
 5 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/batik/1.9.1.wso2v1/pom.xml b/batik/1.9.1.wso2v1/pom.xml
index 60ef70ab3..7ff10dc0f 100644
--- a/batik/1.9.1.wso2v1/pom.xml
+++ b/batik/1.9.1.wso2v1/pom.xml
@@ -227,7 +227,7 @@
             <id>wso2-nexus</id>
             <name>WSO2 internal Repository</name>
             <url>
-                http://maven.wso2.org/nexus/content/groups/wso2-public/
+                https://maven.wso2.org/nexus/content/groups/wso2-public/
             </url>
             <releases>
                 <enabled>true</enabled>
diff --git a/bsf/3.0.0.wso2v4/pom.xml b/bsf/3.0.0.wso2v4/pom.xml
index 9ca465a6d..4794d8813 100644
--- a/bsf/3.0.0.wso2v4/pom.xml
+++ b/bsf/3.0.0.wso2v4/pom.xml
@@ -40,7 +40,7 @@
     <repositories>
     	<repository>
       	  <id>java.net</id>
-      	  <url>http://repo1.maven.org/maven2/</url>
+      	  <url>https://repo1.maven.org/maven2/</url>
     	</repository>
    </repositories>
 
diff --git a/commons-io/2.11.0.wso2v1/pom.xml b/commons-io/2.11.0.wso2v1/pom.xml
index 8a45cbf3f..356b12c34 100644
--- a/commons-io/2.11.0.wso2v1/pom.xml
+++ b/commons-io/2.11.0.wso2v1/pom.xml
@@ -34,13 +34,13 @@
         <repository>
             <id>wso2.releases</id>
             <name>WSO2 internal Repository</name>
-            <url>http://maven.wso2.org/nexus/content/repositories/releases/</url>
+            <url>https://maven.wso2.org/nexus/content/repositories/releases/</url>
         </repository>
 
         <snapshotRepository>
             <id>wso2.snapshots</id>
             <name>Apache Snapshot Repository</name>
-            <url>http://maven.wso2.org/nexus/content/repositories/snapshots/</url>
+            <url>https://maven.wso2.org/nexus/content/repositories/snapshots/</url>
         </snapshotRepository>
     </distributionManagement>
 
@@ -48,7 +48,7 @@
         <repository>
             <id>wso2-nexus</id>
             <name>WSO2 internal Repository</name>
-            <url>http://maven.wso2.org/nexus/content/groups/wso2-public/</url>
+            <url>https://maven.wso2.org/nexus/content/groups/wso2-public/</url>
             <releases>
                 <enabled>true</enabled>
                 <updatePolicy>daily</updatePolicy>
diff --git a/openjpa-all/3.0.0.wso2v1/pom.xml b/openjpa-all/3.0.0.wso2v1/pom.xml
index 1310708a7..ba92bebee 100644
--- a/openjpa-all/3.0.0.wso2v1/pom.xml
+++ b/openjpa-all/3.0.0.wso2v1/pom.xml
@@ -34,7 +34,7 @@
         <repository>
             <id>wso2-nexus</id>
             <name>WSO2 internal Repository</name>
-            <url>http://maven.wso2.org/nexus/content/groups/wso2-public/</url>
+            <url>https://maven.wso2.org/nexus/content/groups/wso2-public/</url>
             <releases>
                 <enabled>true</enabled>
                 <updatePolicy>daily</updatePolicy>
@@ -47,13 +47,13 @@
         <repository>
             <id>wso2.releases</id>
             <name>WSO2 internal Repository</name>
-            <url>http://maven.wso2.org/nexus/content/repositories/releases/</url>
+            <url>https://maven.wso2.org/nexus/content/repositories/releases/</url>
         </repository>
 
         <snapshotRepository>
             <id>wso2.snapshots</id>
             <name>Apache Snapshot Repository</name>
-            <url>http://maven.wso2.org/nexus/content/repositories/snapshots/</url>
+            <url>https://maven.wso2.org/nexus/content/repositories/snapshots/</url>
         </snapshotRepository>
     </distributionManagement>
 
diff --git a/ua-parser/1.5.2.wso2v1/pom.xml b/ua-parser/1.5.2.wso2v1/pom.xml
index f65fafc3b..a05b7bbcd 100644
--- a/ua-parser/1.5.2.wso2v1/pom.xml
+++ b/ua-parser/1.5.2.wso2v1/pom.xml
@@ -34,7 +34,7 @@
         <repository>
             <id>maven-twttr</id>
             <name>Twitter Public Maven Repo</name>
-            <url>http://maven.twttr.com</url>
+            <url>https://maven.twttr.com</url>
         </repository>
     </repositories>