Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dashboard] Cannot delete generated widgets #1079

Closed
lasanthaS opened this issue Sep 18, 2018 · 3 comments
Closed

[Dashboard] Cannot delete generated widgets #1079

lasanthaS opened this issue Sep 18, 2018 · 3 comments

Comments

@lasanthaS
Copy link
Contributor

Description:
In the current implementation, once a widget is generated via the 'Widget generation wizard' it is getting stored in the underlying database. But there is no functionality to delete these widgets once they are added.

This can be a problem if the user has added the widget mistakenly.

Affected Product Version:
WSO2SP 4.3.0

@lasanthaS
Copy link
Contributor Author

This can be implemented by introducing a Widget store to list down all the widgets. If a custom widget is not used in any of the dashboards, then the store will show an option to delete the widget from the store.

@TanyaM
Copy link
Contributor

TanyaM commented Sep 27, 2018

We have an existing api to delete a generated widget from the database but this api has a bug at [1] as we pass widget type as CUSTOM.

[1] https://github.com/wso2/carbon-dashboards/blob/master/components/dashboards/org.wso2.carbon.dashboards.core/src/main/java/org/wso2/carbon/dashboards/core/internal/WidgetMetadataProviderImpl.java#L100

@niveathika
Copy link
Member

This is introduced from SP-4.4.0-M14

@niveathika niveathika added this to the 4.4.0 milestone Jan 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants