Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proto parser has limitations (feature/grpc branch) #2374

Open
DDH13 opened this issue May 15, 2024 · 0 comments
Open

Proto parser has limitations (feature/grpc branch) #2374

DDH13 opened this issue May 15, 2024 · 0 comments

Comments

@DDH13
Copy link
Contributor

DDH13 commented May 15, 2024

Description:
Handwritten parser for proto files in the config deployer has some limitations. It uses regex to match blocks surrounded by curly braces starting with the 'service' keyword to identify gRPC services and then the 'rpc' keyword to match gRPC methods. However, this may lead to issues in situations where nested curly braces exist. Furthermore, the basepath and version is also parsed from the package name of the proto file and an incorrectly formatted package name might cause issues.
An alternative method for parsing would to be modify the parser to take in proto files that are already compiled using the standard proto-compiler and then use the standard libraries to extract the relevant information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants