Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of Throttle Param Processing to work with sync mode #1847

Closed
Tracked by #1791
rmsamitha opened this issue May 18, 2023 · 4 comments
Closed
Tracked by #1791

Implementation of Throttle Param Processing to work with sync mode #1847

rmsamitha opened this issue May 18, 2023 · 4 comments

Comments

@rmsamitha
Copy link
Member

rmsamitha commented May 18, 2023

Existing code implementation has an asynchronous throttle parameter syncing approach.
Since the new feature is introduced also keeping the previous behaviour too, have to implement the new sync mode code flow, abiding to the old flow, without breaking that.

@rmsamitha
Copy link
Member Author

18/05/2023: Updating the condition of "canAccessIfUnitTimeNotOver" is done.
(canAccessIfUnitTimeOver has to be updated next)

@rmsamitha
Copy link
Member Author

19/05/2023: Updating the condition of "canAccessIfUnitTimeOver" is done.

@rmsamitha
Copy link
Member Author

23/05/2023 : Changed the previous implementation to use interface/abstraction based implementation. Used the new HybridThrottleProcessor class which implements DistributedThrottleProcessor interface.

@rmsamitha
Copy link
Member Author

26/03/2023: Changed the code to use a single Redis call instead of two calls per each api request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant