Skip to content

Commit f74bc68

Browse files
Merge pull request #80 from SachiniSiriwardene/test-M1
Add error page when routing to settings page without user login
2 parents d0aff62 + 3df2d08 commit f74bc68

File tree

2 files changed

+10
-4
lines changed

2 files changed

+10
-4
lines changed

package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "devportal-webapp",
3-
"version": "1.0.68",
3+
"version": "1.0.70",
44
"description": "devportal-webapp",
55
"main": "index.js",
66
"scripts": {

src/controllers/settingsController.js

+9-3
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,14 @@ const loadSettingPage = async (req, res) => {
3535
//retrieve orgID from the user object
3636
if (req.user) {
3737
orgID = req.user[constants.ORG_ID];
38+
} else {
39+
let orgName = req.params.orgName;
40+
orgID = await adminDao.getOrgId(orgName);
41+
const templatePath = path.join(require.main.filename, '..', 'pages', 'error-page', 'page.hbs');
42+
const templateResponse = fs.readFileSync(templatePath, constants.CHARSET_UTF8);
43+
const layoutResponse = await loadLayoutFromAPI(orgID);
44+
let html = await renderGivenTemplate(templateResponse, layoutResponse, {});
45+
return res.send(html);
3846
}
3947

4048
let templateContent = {
@@ -43,15 +51,14 @@ const loadSettingPage = async (req, res) => {
4351
orgContent: true
4452
}
4553
let layoutResponse = "";
54+
let views;
4655
try {
4756
if (config.mode === constants.DEV_MODE) {
4857
const retrievedIDP = await getMockIdentityProvider();
4958
templateContent.idp = retrievedIDP;
5059
views = [{
5160
'name': 'Default'
5261
}]
53-
}
54-
if (views && views.length > 0) {
5562
templateContent.content = true;
5663
templateContent.orgContent = false;
5764
templateContent.views = views;
@@ -64,7 +71,6 @@ const loadSettingPage = async (req, res) => {
6471
}
6572
//TODO: fetch view names from DB
6673
const file = await adminService.getOrgContent(orgID, 'layout', 'main.hbs', 'layout');
67-
let views;
6874
if (file !== null) {
6975
views = [{
7076
'name': 'Default'

0 commit comments

Comments
 (0)