Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FVTT 0.8.x support #52

Closed
12 of 13 tasks
wrycu opened this issue Jun 29, 2021 · 4 comments
Closed
12 of 13 tasks

FVTT 0.8.x support #52

wrycu opened this issue Jun 29, 2021 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@wrycu
Copy link
Owner

wrycu commented Jun 29, 2021

Check the following:

  • Settings save/load properly
  • Scene menu works
  • Attack animations work, including custom ones, restoring to default, and rolling dice from weapons/skills
  • Talent checker works and adds the expected status when relevant (with and without statusiconcounter)
  • Opening crawls can be created and launched
  • Auto-renaming of characters for combat works properly
  • Dice helper works properly
  • Strain combat reminder works properly
  • Shop setup, recreation, and purchasing works properly
  • Data pad creator works
  • Bounty creator works

And further oddities:

  • File pickers are the relevant kind (image, video, audio)
  • Intro crawl sound is no longer tied to the intro crawl window - we need to find some way to cancel the sound if the window is closed
@wrycu wrycu added the bug Something isn't working label Jun 29, 2021
@wrycu wrycu self-assigned this Jun 29, 2021
@wrycu
Copy link
Owner Author

wrycu commented Jun 29, 2021

Right off the bat, settings are not loading properly:
image
and the scene menu is not working:
image

@wrycu wrycu changed the title FVTTT 0.8.x support FVTT 0.8.x support Jun 29, 2021
wrycu pushed a commit that referenced this issue Jul 3, 2021
wrycu pushed a commit that referenced this issue Jul 3, 2021
wrycu pushed a commit that referenced this issue Jul 3, 2021
wrycu pushed a commit that referenced this issue Jul 5, 2021
@wrycu wrycu closed this as completed in f7e7be0 Jul 12, 2021
@wrycu wrycu reopened this Jul 12, 2021
wrycu pushed a commit that referenced this issue Jul 13, 2021
* provides 0.9.x compatability
* now refers to friendly NPCs as NPC rather than PC

#52
wrycu pushed a commit that referenced this issue Jul 13, 2021
wrycu pushed a commit that referenced this issue Jul 13, 2021
wrycu pushed a commit that referenced this issue Jul 14, 2021
wrycu pushed a commit that referenced this issue Jul 14, 2021
@wrycu
Copy link
Owner Author

wrycu commented Jul 14, 2021

I'm going to give things a once over again to make sure everything is working, but I believe we now support 0.8.x. I've also addressed any deprecation warnings for 0.9.x, so hopefully the transition there is smoother.

@wrycu
Copy link
Owner Author

wrycu commented Jul 15, 2021

Remaining items from my last pass:

  • Custom attack animations per item are throwing 0.9.x warnings
  • Attack animations are generating 0.9.x warnings
  • NPC re-namer should only run on GM side
  • Shop generation is not properly deleting old items
  • Strain reminder should only run on GM side
  • Custom attack animation browser is an image browser

wrycu pushed a commit that referenced this issue Jul 15, 2021
wrycu pushed a commit that referenced this issue Jul 15, 2021
wrycu pushed a commit that referenced this issue Jul 15, 2021
wrycu pushed a commit that referenced this issue Jul 16, 2021
@wrycu
Copy link
Owner Author

wrycu commented Jul 16, 2021

okay, this is good to go. I'll close it out. I want to improve the shop a bit more (#56) and close #51 and I'll make a 0.8.x release.

@wrycu wrycu closed this as completed Jul 16, 2021
@wrycu wrycu added this to the release-0.2.0 milestone Jul 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant