Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Animations per item #31

Closed
Havoclivekiller opened this issue May 19, 2021 · 4 comments
Closed

[Feature] Animations per item #31

Havoclivekiller opened this issue May 19, 2021 · 4 comments
Assignees
@wrycu
Labels
enhancement New feature or request

Comments

@Havoclivekiller
Copy link

Allow an override to the animations per item. There are some weapons like grenades or different types of melee weapons that would benefit from a different animation (or none at all).

I think you could either add another tab in the item sheet or have these settings under the Configuration tab.
@wrycu wrycu added the enhancement New feature or request label May 19, 2021
wrycu pushed a commit that referenced this issue May 20, 2021
feat: animations per item
f3d0c40 
* identify item being used in each roll

#31
@wrycu wrycu self-assigned this May 20, 2021
@wrycu
Copy link
Owner

wrycu commented May 21, 2021

I'm working on implementing this.

wrycu pushed a commit that referenced this issue May 21, 2021
feat: animations per item
d496ae3 
* read flag data set on a per-item basis and use that instead of generic skill setting
* NOTE: this doesn't deal with setting the data -  that's still pending

#31
wrycu pushed a commit that referenced this issue May 22, 2021
feat: animations per item
2296ba7 
* working animation per item (MVP)

#31
@wrycu
Copy link
Owner

wrycu commented May 22, 2021

I've got it working, but have a bit of work left to do to clean things up. Here's how it looks:

image

image

It's not entirely ideal since you can't set it from the item sheet itself, but I couldn't find a clean way to do it without a ton of work.

@Havoclivekiller
Copy link
Author

Sure. Let's hope it will work without issues. Good job.

wrycu pushed a commit that referenced this issue May 23, 2021
feat: animations per item
d1e588f 
* add localization support
* update UI icon
* add UI messages on success and failure

#31
@wrycu
Copy link
Owner

wrycu commented May 23, 2021

Done. Will be released in 0.1.8.

@wrycu wrycu closed this as completed May 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wrycu wrycu

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wrycu @Havoclivekiller