Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Compatability] JB2A Patreon Pack #27

Closed
Havoclivekiller opened this issue May 19, 2021 · 3 comments
Closed

[Compatability] JB2A Patreon Pack #27

Havoclivekiller opened this issue May 19, 2021 · 3 comments
Assignees
@wrycu
Labels
enhancement New feature or request

Comments

@Havoclivekiller
Copy link

I've the patreon pack of JB2A animations but the module requires me to use the non-patreon version. Won't launch without it.
@wrycu wrycu added the enhancement New feature or request label May 19, 2021
@wrycu
Copy link
Owner

wrycu commented May 19, 2021

Yeah, I'm looking for a better solution for this. The problem is that you can't declare optional dependencies and can't allow >1 module to fulfil a dependency. The other way I can think of doing it is to not require JB2A at all, but that results in a worse UX for users who don't have either.

I'm open to ideas on how to solve this, if you have any.

@Havoclivekiller
Copy link
Author

My suggestion is to remove the dependency. Have a popup when a Gamemaster logs in with the Star Wars Enhancement info, there you could have a warning that the module has animations but needs JB2A pack (patreon or not). Disable all animations until the module detects the JB2A is activated.

wrycu pushed a commit that referenced this issue May 19, 2021
chore: update dependencies
8793c2a 
#27
@wrycu wrycu self-assigned this May 19, 2021
wrycu pushed a commit that referenced this issue May 19, 2021
fix: improve support for JB2A
852dec5 
* detect if either JB2A module is not loaded and disable attack animations if appropriate
* replaces having JB2A as a dependency

closes #27
@wrycu
Copy link
Owner

wrycu commented May 19, 2021

Done. Will be released in 0.1.8.

@wrycu wrycu closed this as completed May 19, 2021
@wrycu wrycu mentioned this issue May 20, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wrycu wrycu

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wrycu @Havoclivekiller