Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explore shop generator #26

Closed
wrycu opened this issue Apr 25, 2021 · 7 comments
Closed

Explore shop generator #26

wrycu opened this issue Apr 25, 2021 · 7 comments
Assignees
Labels

Comments

@wrycu
Copy link
Owner

wrycu commented Apr 25, 2021

Similar to https://www.swrpg-shop.com/. Perhaps from in-game items.

The current workflow to get a shop up is to create a new actor and change their sheet to the "vendor" type. I have added a scene button to create it as well, but it isn't functional right now (it'll error out and quit).

@wrycu wrycu added the feature label Apr 25, 2021
wrycu pushed a commit that referenced this issue Apr 27, 2021
wrycu pushed a commit that referenced this issue Apr 27, 2021
wrycu pushed a commit that referenced this issue Apr 27, 2021
* contains an MVP shop generator (#26)
* contains early WIP hyperspace transition (#12)
@wrycu
Copy link
Owner Author

wrycu commented Apr 27, 2021

todo:

  • Add localization support
  • Support specific item types (e.g. exclude shipweapons from the "weapon" store)
  • Merge in the changes from @Rysarian, which permit using local items
  • Make things configurable, e.g. compendium names, local item support
  • Investigate better shop output options
  • Add automatic credit deduction
  • Add chat messages on item purchase
  • Add item delete for GM, hide stock refresh for player
  • Re-work scene shop generator button to create an actor and populate the inventory
  • Figure out price information for drag-and-drop items
  • Add check for compendiums before using them
  • Clean up code (add proper logging, remove the millions of log statements currently being spewed, document functions and functionality, etc)

For better shop output options, I'm thinking about a scene such as this:
image
Alternatively, it's been suggested to implement something like a vendor sheet

@wrycu wrycu self-assigned this Apr 27, 2021
@Sonny-Crockett
Copy link

  • I think having a global discount or upcharge that could be affected by (%) would be useful.

  • The ability to manually add items from the compendium to an already generated list would be great to make sure a certain item was there on a "fixed" list provided for players. If an NPC sheet would be used in addition to the table this is a moot point as one could do this already by dragging items.

General Shopping Discussion: Reddit Link

wrycu pushed a commit that referenced this issue Apr 28, 2021
* correct NaN price for non-weapons
* add note for restricted items to shop
* add support for item attachments
* limit items in compendiums to the relevant item type

#26
wrycu pushed a commit that referenced this issue Apr 28, 2021
* add merchant discount / upcharge as a percent of base price

#26
wrycu pushed a commit that referenced this issue Apr 30, 2021
* first pass as a vendor shop keep
* rough chat outline
* everything is messy and barely functional

#26
wrycu pushed a commit that referenced this issue May 1, 2021
* shop generation for actors works
* purchase of items works

#26
wrycu pushed a commit that referenced this issue May 1, 2021
* add vendor inventory scrolling

#26
wrycu pushed a commit that referenced this issue May 1, 2021
* add chat messages on item purchase

#26
@wrycu
Copy link
Owner Author

wrycu commented May 1, 2021

@Sonny-Crockett drag and drop items are now supported. In theory this will work, though in practice I've only tested it with drag-and-dropped items from the local world.

wrycu pushed a commit that referenced this issue May 1, 2021
* clean up file names

#26
wrycu pushed a commit that referenced this issue May 1, 2021
* add delete item for GM, hide GM actions for PCs

#26
@wrycu
Copy link
Owner Author

wrycu commented May 2, 2021

I'm considering hiding the roll result from the players. The GM can do something with it if they want, but I don't think there's any value in the PCs seeing it.

wrycu pushed a commit that referenced this issue May 2, 2021
* improved first-time setup - UI button now works

#26
wrycu pushed a commit that referenced this issue May 2, 2021
* set price on drag-and-drop items

#26
@wrycu
Copy link
Owner Author

wrycu commented May 2, 2021

The above-commit requires regenerating shop inventory or it'll break.

wrycu pushed a commit that referenced this issue May 2, 2021
* handle missing compendiums gracefully

#26
wrycu pushed a commit that referenced this issue May 2, 2021
* code refactor to be slightly less janky
* improved logging and comments
* fixed bug for core world items

#26
wrycu pushed a commit that referenced this issue May 2, 2021
* add localization

#26
@wrycu
Copy link
Owner Author

wrycu commented May 2, 2021

This is now reasonably complete. I'm gonna start using it and looking for ways to improve it / bugs which need fixing.

wrycu referenced this issue May 3, 2021
add fix for users with no player-owned actors
wrycu pushed a commit that referenced this issue May 6, 2021
* correct bug with price modifier breaking the shop

#26
@wrycu
Copy link
Owner Author

wrycu commented May 6, 2021

Need to fix the restricted tag for auto-added items.

wrycu pushed a commit that referenced this issue May 7, 2021
* fix for items persisting through page reloads
* add generic item pictures rather than mystery_man

#26
wrycu pushed a commit that referenced this issue May 7, 2021
* correctly detect restricted items for generated content

#26
wrycu pushed a commit that referenced this issue May 7, 2021
* fix for swapped negotiation and streetwise rolls. whoops!

#26
wrycu pushed a commit that referenced this issue May 7, 2021
* fix generic icon for armor (the system uses the british spelling)

#26
wrycu pushed a commit that referenced this issue May 7, 2021
* remove unused nerfherder setup option (will re-add when I figure out how to limit results to consumables)

#26
@wrycu wrycu closed this as completed May 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants