Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ntcore] Clarify persistent json warning message #4980

Closed
PeterJohnson opened this issue Jan 20, 2023 · 0 comments · Fixed by #4996
Closed

[ntcore] Clarify persistent json warning message #4980

PeterJohnson opened this issue Jan 20, 2023 · 0 comments · Fixed by #4996
Labels
component: ntcore NetworkTables library

Comments

@PeterJohnson
Copy link
Member

Several reports of this being confusing to teams and it being a nuisance message. Two potential solutions (and potentially both could be implemented):

  • Add more context to the message, clarifying that this message is not a concern unless the team is expecting persistent values to be loaded.
  • Write an empty persistent file if one does not exist; this will make the message only appear once in typical use cases (as the next startup an empty file will exist).

The latter is essentially what the NT3 implementation did, which is why this message appears to be "new".

@PeterJohnson PeterJohnson added the component: ntcore NetworkTables library label Jan 20, 2023
@Starlight220 Starlight220 linked a pull request Jan 22, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: ntcore NetworkTables library
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants