diff --git a/includes/admin/class-general.php b/includes/admin/class-general.php index c761529f..6fb8810e 100644 --- a/includes/admin/class-general.php +++ b/includes/admin/class-general.php @@ -76,7 +76,7 @@ public static function get_fields() { . ( defined( 'NO_QL_SESSION_HANDLER' ) ? __( ' This setting is disabled. The "NO_QL_SESSION_HANDLER" flag has been triggered with code', 'wp-graphql-woocommerce' ) : '' ), 'type' => 'checkbox', 'value' => defined( 'NO_QL_SESSION_HANDLER' ) ? 'on' : woographql_setting( 'disable_ql_session_handler', 'off' ), - 'disabled' => defined( 'NO_QL_SESSION_HANDLER' ) ? true : false, + 'disabled' => defined( 'NO_QL_SESSION_HANDLER' ), ], [ 'name' => 'enable_unsupported_product_type', @@ -101,7 +101,7 @@ public static function get_fields() { ] ), 'value' => $enable_auth_urls_hardcoded ? $all_urls_checked : woographql_setting( 'enable_authorizing_url_fields', [] ), - 'disabled' => $enable_auth_urls_hardcoded ? true : false, + 'disabled' => $enable_auth_urls_hardcoded, 'sanitize_callback' => static function( $value ) { if ( empty( $value ) ) { return []; diff --git a/includes/connection/class-products.php b/includes/connection/class-products.php index 28f6714d..e52d1d5f 100644 --- a/includes/connection/class-products.php +++ b/includes/connection/class-products.php @@ -398,7 +398,7 @@ public static function bypass_get_args_sanitization( $args, $connection_resolver * @return \WPGraphQL\Data\Connection\PostObjectConnectionResolver */ public static function set_ordering_query_args( $resolver, $args ) { - $backward = isset( $args['last'] ) ? true : false; + $backward = isset( $args['last'] ); if ( ! empty( $args['where']['orderby'] ) ) { $default_fields = [ diff --git a/includes/connection/class-wc-terms.php b/includes/connection/class-wc-terms.php index b5febd2f..a8ca83d3 100644 --- a/includes/connection/class-wc-terms.php +++ b/includes/connection/class-wc-terms.php @@ -40,7 +40,7 @@ public static function register_connections() { $wc_post_types = WP_GraphQL_WooCommerce::get_post_types(); // Loop through the allowed_taxonomies to register appropriate connections. - foreach ( $allowed_taxonomies as $taxonomy => $tax_object ) { + foreach ( $allowed_taxonomies as $tax_object ) { foreach ( $wc_post_types as $post_type ) { if ( 'product' === $post_type ) { continue; diff --git a/includes/data/connection/class-cart-item-connection-resolver.php b/includes/data/connection/class-cart-item-connection-resolver.php index 51ada725..88c127e8 100644 --- a/includes/data/connection/class-cart-item-connection-resolver.php +++ b/includes/data/connection/class-cart-item-connection-resolver.php @@ -103,9 +103,7 @@ public function get_query() { * {@inheritDoc} */ public function get_ids_from_query() { - $ids = ! empty( $this->query ) ? $this->query : []; - - return $ids; + return ! empty( $this->query ) ? $this->query : []; } /** diff --git a/includes/data/connection/class-downloadable-item-connection-resolver.php b/includes/data/connection/class-downloadable-item-connection-resolver.php index 0203de2e..c91646d8 100644 --- a/includes/data/connection/class-downloadable-item-connection-resolver.php +++ b/includes/data/connection/class-downloadable-item-connection-resolver.php @@ -140,9 +140,7 @@ public function get_query() { * @return array */ public function get_ids_from_query() { - $ids = ! empty( $this->query ) ? $this->query : []; - - return $ids; + return ! empty( $this->query ) ? $this->query : []; } /** diff --git a/includes/data/connection/class-order-item-connection-resolver.php b/includes/data/connection/class-order-item-connection-resolver.php index f580b1da..71137828 100644 --- a/includes/data/connection/class-order-item-connection-resolver.php +++ b/includes/data/connection/class-order-item-connection-resolver.php @@ -99,7 +99,7 @@ public function get_query() { }//end switch $items = []; - foreach ( $this->source->get_items( $type ) as $id => $item ) { + foreach ( $this->source->get_items( $type ) as $item ) { $items[] = $item; } diff --git a/includes/data/mutation/class-order-mutation.php b/includes/data/mutation/class-order-mutation.php index f9e7cb02..1e62aced 100644 --- a/includes/data/mutation/class-order-mutation.php +++ b/includes/data/mutation/class-order-mutation.php @@ -262,8 +262,7 @@ protected static function get_order_item_keys( $type ) { * @param array $item_keys Order item keys. * @param string $type Order item type slug. */ - $item_keys = apply_filters( 'woographql_get_order_item_keys', [], $type ); - return $item_keys; + return apply_filters( 'woographql_get_order_item_keys', [], $type ); }//end switch } diff --git a/includes/model/class-order.php b/includes/model/class-order.php index 2da873a8..a473cca4 100644 --- a/includes/model/class-order.php +++ b/includes/model/class-order.php @@ -299,7 +299,7 @@ protected function owner_matches_current_user() { } // If customer ID matches current user, return true. - return absint( $customer_id ) === absint( $this->current_user->ID ) ? true : false; + return absint( $customer_id ) === absint( $this->current_user->ID ); } /** @@ -327,7 +327,7 @@ public function guest_order_customer_matches_current_user() { } // If customer email matches current user, return true. - return $customer_email === $session_customer->get_billing_email() ? true : false; + return $customer_email === $session_customer->get_billing_email(); } /** @@ -336,7 +336,7 @@ public function guest_order_customer_matches_current_user() { * @return bool */ public function is_private() { - return wc_is_order_status( 'wc-' . $this->data->get_status() ) ? false : true; + return ! wc_is_order_status( 'wc-' . $this->data->get_status() ); } /** diff --git a/includes/mutation/class-cart-add-fee.php b/includes/mutation/class-cart-add-fee.php index 6432f2ed..68a2e8d7 100644 --- a/includes/mutation/class-cart-add-fee.php +++ b/includes/mutation/class-cart-add-fee.php @@ -42,7 +42,7 @@ public static function register_mutation() { * @return array */ public static function get_input_fields() { - $input_fields = [ + return [ 'name' => [ 'type' => [ 'non_null' => 'String' ], 'description' => __( 'Unique name for the fee.', 'wp-graphql-woocommerce' ), @@ -60,8 +60,6 @@ public static function get_input_fields() { 'description' => __( 'The tax class for the fee if taxable.', 'wp-graphql-woocommerce' ), ], ]; - - return $input_fields; } /** diff --git a/includes/mutation/class-cart-add-item.php b/includes/mutation/class-cart-add-item.php index 3acf779b..32be9e56 100644 --- a/includes/mutation/class-cart-add-item.php +++ b/includes/mutation/class-cart-add-item.php @@ -76,9 +76,7 @@ public static function get_output_fields() { 'cartItem' => [ 'type' => 'CartItem', 'resolve' => static function ( $payload ) { - $item = \WC()->cart->get_cart_item( $payload['key'] ); - - return $item; + return \WC()->cart->get_cart_item( $payload['key'] ); }, ], 'cart' => Cart_Mutation::get_cart_field( true ), diff --git a/includes/mutation/class-order-create.php b/includes/mutation/class-order-create.php index 60b05b35..f72db75e 100644 --- a/includes/mutation/class-order-create.php +++ b/includes/mutation/class-order-create.php @@ -44,7 +44,7 @@ public static function register_mutation() { * @return array */ public static function get_input_fields() { - $input_fields = [ + return [ 'parentId' => [ 'type' => 'Int', 'description' => __( 'Parent order ID.', 'wp-graphql-woocommerce' ), @@ -110,8 +110,6 @@ public static function get_input_fields() { 'description' => __( 'Define if the order is paid. It will set the status to processing and reduce stock items.', 'wp-graphql-woocommerce' ), ], ]; - - return $input_fields; } /** diff --git a/includes/mutation/class-order-update.php b/includes/mutation/class-order-update.php index 1856760c..785008c3 100644 --- a/includes/mutation/class-order-update.php +++ b/includes/mutation/class-order-update.php @@ -150,8 +150,8 @@ public static function mutate_and_get_payload() { // Actions for after the order is saved. if ( true === $input['isPaid'] ) { $order->payment_complete( - ! empty( $input['transactionId'] ) ? - $input['transactionId'] + ! empty( $input['transactionId'] ) + ? $input['transactionId'] : '' ); } diff --git a/includes/type/object/class-customer-type.php b/includes/type/object/class-customer-type.php index 4c085367..a208bede 100644 --- a/includes/type/object/class-customer-type.php +++ b/includes/type/object/class-customer-type.php @@ -237,13 +237,12 @@ public static function register() { 'description' => __( 'Customer\'s stored payment tokens.', 'wp-graphql-woocommerce' ), 'resolve' => static function( $source ) { if ( get_current_user_id() === $source->ID ) { - $tokens = array_filter( + return array_filter( array_values( \WC_Payment_Tokens::get_customer_tokens( $source->ID ) ), static function ( $token ) { return 'CC' === $token->get_type(); } ); - return $tokens; } throw new UserError( __( 'Not authorized to view this user\'s payment methods.', 'wp-graphql-woocommerce' ) ); @@ -254,13 +253,12 @@ static function ( $token ) { 'description' => __( 'Customer\'s stored payment tokens.', 'wp-graphql-woocommerce' ), 'resolve' => static function( $source ) { if ( get_current_user_id() === $source->ID ) { - $tokens = array_filter( + return array_filter( array_values( \WC_Payment_Tokens::get_customer_tokens( $source->ID ) ), static function ( $token ) { return 'eCheck' === $token->get_type(); } ); - return $tokens; } throw new UserError( __( 'Not authorized to view this user\'s payment methods.', 'wp-graphql-woocommerce' ) ); diff --git a/includes/type/object/class-meta-data-type.php b/includes/type/object/class-meta-data-type.php index 9ee32a60..96d654c2 100644 --- a/includes/type/object/class-meta-data-type.php +++ b/includes/type/object/class-meta-data-type.php @@ -85,7 +85,7 @@ public static function get_metadata_field_definition() { ], 'resolve' => static function( $source, array $args ) { // Set unique flag. - $single = ! empty( $args['multiple'] ) ? false : true; + $single = empty( $args['multiple'] ); // Check "key" argument and format meta_data objects. if ( ! empty( $args['key'] ) && $source->meta_exists( $args['key'] ) ) { diff --git a/includes/type/object/class-root-query.php b/includes/type/object/class-root-query.php index c6f897b5..2691dc2f 100644 --- a/includes/type/object/class-root-query.php +++ b/includes/type/object/class-root-query.php @@ -586,9 +586,7 @@ public static function register_fields() { throw new UserError( sprintf( __( 'No product exists with the %1$s: %2$s', 'wp-graphql-woocommerce' ), $id_type, $product_id ) ); } - $product = Factory::resolve_crud_object( $product_id, $context ); - - return $product; + return Factory::resolve_crud_object( $product_id, $context ); }, ] ); diff --git a/includes/utils/class-transfer-session-handler.php b/includes/utils/class-transfer-session-handler.php index 699c1940..dfd3dbd5 100644 --- a/includes/utils/class-transfer-session-handler.php +++ b/includes/utils/class-transfer-session-handler.php @@ -107,8 +107,6 @@ public function get_client_session_id() { return $client_session_id; } - $client_session_id = ''; - - return $client_session_id; + return ''; } }