Fix: correctly check paths when running scaffold command for themes and plugins from outside directory. #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `wp-i18n` node module has some PHP that gets flagged.
Allow for `installation` as well as `install`
Ignore 'node_modules' in PHPCS XML file
When the request fails on HTTPS, we switch to HTTP instead, which should work within Travis. Fixes wp-cli#181
…ssue Work around Travis CI issue with _s download certificate
Add support for Probot `move` command
Fix typo in Travis config
Missing text domain in post_type_extended.mustache
…E is wordpress-0.0-beta1 or wordpress-0.0-RC1
…-block Add textdomain to block js strings and Update test accordingly
…upport-beta-rc In the case of RC and Beta, use Branch for WP_TEST_TAG.
Doing so ensures environment variables are passed through and avoids cryptic build failures.
Run `docker-php-ext-install` with `sudo -E` in CircleCI
Split up the list of expected files to allow for WP 5.0+ changes
Specifically: * `.babelrc` * `.eslintignore` * `.eslintignore` * `.eslintignore`
Ignore various JavaScript config files in plugin `.distignore`
Allow Composer plugins to run
Add php 8.1 support
This reverts commit 04119db.
Allow for diverging PHPUnit version specifics in tests
parent_dir contains a normalized path whereas WP_CONTENT_DIR contains a relative path. By running the WP_CONTENT_DIR through realpath we get a path we can actually compare between the target dir and where we want to place the new theme. Also fixes wp-cli#251
NielsdeBlaauw
changed the title
|
If I remember correctly the tests failed from the start right? |
|
Proceeding with wp-cli/wp-cli#5594 for this repository. I've captured this PR to https://gist.github.com/danielbachhuber/2951826b5cee4db3c8245ff095d5b7de in case this PR is auto-closed or broken in some way. |
danielbachhuber
force-pushed
the
master
branch
from
12df858
to
aa481f2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
parent_dir contains a normalized path whereas WP_CONTENT_DIR contains a relative path. By running the WP_CONTENT_DIR through realpath we get a path we can actually compare between the target dir and where we want to place the new theme.
Fixes #263
Also fixes #251