Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review 5.4 Changes #465

Open
bhubbard opened this issue Feb 25, 2020 · 1 comment
Open

Review 5.4 Changes #465

bhubbard opened this issue Feb 25, 2020 · 1 comment

Comments

@bhubbard
Copy link
Member

Review how 5.4 changes can be used to improve our navwalker.

WordPress 5.4 Introduces new hooks to add custom fields to menu items

@IanDelMar
Copy link
Collaborator

I have looked into this and while it would be useful in terms how easily one can configure menu items, when using custom fields you add database calls reducing the performance of the nav walker (without caching). If the first outweighs the latter WP Bootstrap Navwalker should definitely use custom fields, if not one should forget about the custom fields. Custom fields also add to lower maintainability (set up and save custom fields, and so on). My preference: no custom fields.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants