Skip to content

Commit 8ac3c4c

Browse files
committed
Have all visible internal function names end with an underscore.
We haven't had a convention for naming internal functions in -internal.h versus naming visible functions in include/**.h. This patch changes every function declared in a -internal.h file to be named ending with an underscore. Static function names are unaffected, since there's no risk of calling them from outside Libevent. This is an automatic conversion. The script that produced was made by running the following script over the output of ctags --c-kinds=pf -o - *-internal.h | cut -f 1 | sort| uniq (GNU ctags was required.) ===== #!/usr/bin/perl -w -n use strict; BEGIN { print "#!/usr/bin/perl -w -i -p\n\n"; } chomp; my $ident = $_; next if ($ident =~ /_$/); next if ($ident =~ /^TAILQ/); my $better = "${ident}_"; print "s/(?<![A-Za-z0-9_])$ident(?![A-Za-z0-9_])/$better/g;\n"; === And then running the script below that it generated over all === the .c and .h files again #!/usr/bin/perl -w -i -p s/(?<![A-Za-z0-9_])bufferevent_async_can_connect(?![A-Za-z0-9_])/bufferevent_async_can_connect_/g; s/(?<![A-Za-z0-9_])bufferevent_async_connect(?![A-Za-z0-9_])/bufferevent_async_connect_/g; s/(?<![A-Za-z0-9_])bufferevent_async_new(?![A-Za-z0-9_])/bufferevent_async_new_/g; s/(?<![A-Za-z0-9_])bufferevent_async_set_connected(?![A-Za-z0-9_])/bufferevent_async_set_connected_/g; s/(?<![A-Za-z0-9_])bufferevent_decref(?![A-Za-z0-9_])/bufferevent_decref_/g; s/(?<![A-Za-z0-9_])bufferevent_disable_hard(?![A-Za-z0-9_])/bufferevent_disable_hard_/g; s/(?<![A-Za-z0-9_])bufferevent_enable_locking(?![A-Za-z0-9_])/bufferevent_enable_locking_/g; s/(?<![A-Za-z0-9_])bufferevent_incref(?![A-Za-z0-9_])/bufferevent_incref_/g; s/(?<![A-Za-z0-9_])bufferevent_init_common(?![A-Za-z0-9_])/bufferevent_init_common_/g; s/(?<![A-Za-z0-9_])bufferevent_remove_from_rate_limit_group_internal(?![A-Za-z0-9_])/bufferevent_remove_from_rate_limit_group_internal_/g; s/(?<![A-Za-z0-9_])bufferevent_suspend_read(?![A-Za-z0-9_])/bufferevent_suspend_read_/g; s/(?<![A-Za-z0-9_])bufferevent_suspend_write(?![A-Za-z0-9_])/bufferevent_suspend_write_/g; s/(?<![A-Za-z0-9_])bufferevent_unsuspend_read(?![A-Za-z0-9_])/bufferevent_unsuspend_read_/g; s/(?<![A-Za-z0-9_])bufferevent_unsuspend_write(?![A-Za-z0-9_])/bufferevent_unsuspend_write_/g; s/(?<![A-Za-z0-9_])evbuffer_commit_read(?![A-Za-z0-9_])/evbuffer_commit_read_/g; s/(?<![A-Za-z0-9_])evbuffer_commit_write(?![A-Za-z0-9_])/evbuffer_commit_write_/g; s/(?<![A-Za-z0-9_])evbuffer_invoke_callbacks(?![A-Za-z0-9_])/evbuffer_invoke_callbacks_/g; s/(?<![A-Za-z0-9_])evbuffer_launch_read(?![A-Za-z0-9_])/evbuffer_launch_read_/g; s/(?<![A-Za-z0-9_])evbuffer_launch_write(?![A-Za-z0-9_])/evbuffer_launch_write_/g; s/(?<![A-Za-z0-9_])evbuffer_overlapped_new(?![A-Za-z0-9_])/evbuffer_overlapped_new_/g; s/(?<![A-Za-z0-9_])evbuffer_set_parent(?![A-Za-z0-9_])/evbuffer_set_parent_/g; s/(?<![A-Za-z0-9_])event_active_nolock(?![A-Za-z0-9_])/event_active_nolock_/g; s/(?<![A-Za-z0-9_])event_base_add_virtual(?![A-Za-z0-9_])/event_base_add_virtual_/g; s/(?<![A-Za-z0-9_])event_base_assert_ok(?![A-Za-z0-9_])/event_base_assert_ok_/g; s/(?<![A-Za-z0-9_])event_base_del_virtual(?![A-Za-z0-9_])/event_base_del_virtual_/g; s/(?<![A-Za-z0-9_])event_base_get_deferred_cb_queue(?![A-Za-z0-9_])/event_base_get_deferred_cb_queue_/g; s/(?<![A-Za-z0-9_])event_base_get_iocp(?![A-Za-z0-9_])/event_base_get_iocp_/g; s/(?<![A-Za-z0-9_])event_base_start_iocp(?![A-Za-z0-9_])/event_base_start_iocp_/g; s/(?<![A-Za-z0-9_])event_base_stop_iocp(?![A-Za-z0-9_])/event_base_stop_iocp_/g; s/(?<![A-Za-z0-9_])event_changelist_add(?![A-Za-z0-9_])/event_changelist_add_/g; s/(?<![A-Za-z0-9_])event_changelist_del(?![A-Za-z0-9_])/event_changelist_del_/g; s/(?<![A-Za-z0-9_])event_changelist_freemem(?![A-Za-z0-9_])/event_changelist_freemem_/g; s/(?<![A-Za-z0-9_])event_changelist_init(?![A-Za-z0-9_])/event_changelist_init_/g; s/(?<![A-Za-z0-9_])event_changelist_remove_all(?![A-Za-z0-9_])/event_changelist_remove_all_/g; s/(?<![A-Za-z0-9_])event_deferred_cb_cancel(?![A-Za-z0-9_])/event_deferred_cb_cancel_/g; s/(?<![A-Za-z0-9_])event_deferred_cb_init(?![A-Za-z0-9_])/event_deferred_cb_init_/g; s/(?<![A-Za-z0-9_])event_deferred_cb_queue_init(?![A-Za-z0-9_])/event_deferred_cb_queue_init_/g; s/(?<![A-Za-z0-9_])event_deferred_cb_schedule(?![A-Za-z0-9_])/event_deferred_cb_schedule_/g; s/(?<![A-Za-z0-9_])event_get_win32_extension_fns(?![A-Za-z0-9_])/event_get_win32_extension_fns_/g; s/(?<![A-Za-z0-9_])event_iocp_activate_overlapped(?![A-Za-z0-9_])/event_iocp_activate_overlapped_/g; s/(?<![A-Za-z0-9_])event_iocp_port_associate(?![A-Za-z0-9_])/event_iocp_port_associate_/g; s/(?<![A-Za-z0-9_])event_iocp_port_launch(?![A-Za-z0-9_])/event_iocp_port_launch_/g; s/(?<![A-Za-z0-9_])event_iocp_shutdown(?![A-Za-z0-9_])/event_iocp_shutdown_/g; s/(?<![A-Za-z0-9_])event_overlapped_init(?![A-Za-z0-9_])/event_overlapped_init_/g; s/(?<![A-Za-z0-9_])evhttp_connection_connect(?![A-Za-z0-9_])/evhttp_connection_connect_/g; s/(?<![A-Za-z0-9_])evhttp_connection_fail(?![A-Za-z0-9_])/evhttp_connection_fail_/g; s/(?<![A-Za-z0-9_])evhttp_connection_reset(?![A-Za-z0-9_])/evhttp_connection_reset_/g; s/(?<![A-Za-z0-9_])evhttp_parse_firstline(?![A-Za-z0-9_])/evhttp_parse_firstline_/g; s/(?<![A-Za-z0-9_])evhttp_parse_headers(?![A-Za-z0-9_])/evhttp_parse_headers_/g; s/(?<![A-Za-z0-9_])evhttp_response_code(?![A-Za-z0-9_])/evhttp_response_code_/g; s/(?<![A-Za-z0-9_])evhttp_send_page(?![A-Za-z0-9_])/evhttp_send_page_/g; s/(?<![A-Za-z0-9_])evhttp_start_read(?![A-Za-z0-9_])/evhttp_start_read_/g; s/(?<![A-Za-z0-9_])EVLOCK_TRY_LOCK(?![A-Za-z0-9_])/EVLOCK_TRY_LOCK_/g; s/(?<![A-Za-z0-9_])evmap_check_integrity(?![A-Za-z0-9_])/evmap_check_integrity_/g; s/(?<![A-Za-z0-9_])evmap_delete_all(?![A-Za-z0-9_])/evmap_delete_all_/g; s/(?<![A-Za-z0-9_])evmap_foreach_event(?![A-Za-z0-9_])/evmap_foreach_event_/g; s/(?<![A-Za-z0-9_])evmap_io_active(?![A-Za-z0-9_])/evmap_io_active_/g; s/(?<![A-Za-z0-9_])evmap_io_add(?![A-Za-z0-9_])/evmap_io_add_/g; s/(?<![A-Za-z0-9_])evmap_io_clear(?![A-Za-z0-9_])/evmap_io_clear_/g; s/(?<![A-Za-z0-9_])evmap_io_del(?![A-Za-z0-9_])/evmap_io_del_/g; s/(?<![A-Za-z0-9_])evmap_io_get_fdinfo(?![A-Za-z0-9_])/evmap_io_get_fdinfo_/g; s/(?<![A-Za-z0-9_])evmap_io_initmap(?![A-Za-z0-9_])/evmap_io_initmap_/g; s/(?<![A-Za-z0-9_])evmap_reinit(?![A-Za-z0-9_])/evmap_reinit_/g; s/(?<![A-Za-z0-9_])evmap_signal_active(?![A-Za-z0-9_])/evmap_signal_active_/g; s/(?<![A-Za-z0-9_])evmap_signal_add(?![A-Za-z0-9_])/evmap_signal_add_/g; s/(?<![A-Za-z0-9_])evmap_signal_clear(?![A-Za-z0-9_])/evmap_signal_clear_/g; s/(?<![A-Za-z0-9_])evmap_signal_del(?![A-Za-z0-9_])/evmap_signal_del_/g; s/(?<![A-Za-z0-9_])evmap_signal_initmap(?![A-Za-z0-9_])/evmap_signal_initmap_/g; s/(?<![A-Za-z0-9_])evrpc_hook_associate_meta(?![A-Za-z0-9_])/evrpc_hook_associate_meta_/g; s/(?<![A-Za-z0-9_])evrpc_hook_context_free(?![A-Za-z0-9_])/evrpc_hook_context_free_/g; s/(?<![A-Za-z0-9_])evrpc_hook_meta_new(?![A-Za-z0-9_])/evrpc_hook_meta_new_/g; s/(?<![A-Za-z0-9_])evrpc_reqstate_free(?![A-Za-z0-9_])/evrpc_reqstate_free_/g; s/(?<![A-Za-z0-9_])evsig_dealloc(?![A-Za-z0-9_])/evsig_dealloc_/g; s/(?<![A-Za-z0-9_])evsig_init(?![A-Za-z0-9_])/evsig_init_/g; s/(?<![A-Za-z0-9_])evsig_set_base(?![A-Za-z0-9_])/evsig_set_base_/g; s/(?<![A-Za-z0-9_])ev_token_bucket_get_tick(?![A-Za-z0-9_])/ev_token_bucket_get_tick_/g; s/(?<![A-Za-z0-9_])ev_token_bucket_init(?![A-Za-z0-9_])/ev_token_bucket_init_/g; s/(?<![A-Za-z0-9_])ev_token_bucket_update(?![A-Za-z0-9_])/ev_token_bucket_update_/g; s/(?<![A-Za-z0-9_])evutil_accept4(?![A-Za-z0-9_])/evutil_accept4_/g; s/(?<![A-Za-z0-9_])evutil_addrinfo_append(?![A-Za-z0-9_])/evutil_addrinfo_append_/g; s/(?<![A-Za-z0-9_])evutil_adjust_hints_for_addrconfig(?![A-Za-z0-9_])/evutil_adjust_hints_for_addrconfig_/g; s/(?<![A-Za-z0-9_])evutil_ersatz_socketpair(?![A-Za-z0-9_])/evutil_ersatz_socketpair_/g; s/(?<![A-Za-z0-9_])evutil_eventfd(?![A-Za-z0-9_])/evutil_eventfd_/g; s/(?<![A-Za-z0-9_])evutil_format_sockaddr_port(?![A-Za-z0-9_])/evutil_format_sockaddr_port_/g; s/(?<![A-Za-z0-9_])evutil_getaddrinfo_async(?![A-Za-z0-9_])/evutil_getaddrinfo_async_/g; s/(?<![A-Za-z0-9_])evutil_getaddrinfo_common(?![A-Za-z0-9_])/evutil_getaddrinfo_common_/g; s/(?<![A-Za-z0-9_])evutil_getenv(?![A-Za-z0-9_])/evutil_getenv_/g; s/(?<![A-Za-z0-9_])evutil_hex_char_to_int(?![A-Za-z0-9_])/evutil_hex_char_to_int_/g; s/(?<![A-Za-z0-9_])EVUTIL_ISALNUM(?![A-Za-z0-9_])/EVUTIL_ISALNUM_/g; s/(?<![A-Za-z0-9_])EVUTIL_ISALPHA(?![A-Za-z0-9_])/EVUTIL_ISALPHA_/g; s/(?<![A-Za-z0-9_])EVUTIL_ISDIGIT(?![A-Za-z0-9_])/EVUTIL_ISDIGIT_/g; s/(?<![A-Za-z0-9_])EVUTIL_ISLOWER(?![A-Za-z0-9_])/EVUTIL_ISLOWER_/g; s/(?<![A-Za-z0-9_])EVUTIL_ISPRINT(?![A-Za-z0-9_])/EVUTIL_ISPRINT_/g; s/(?<![A-Za-z0-9_])EVUTIL_ISSPACE(?![A-Za-z0-9_])/EVUTIL_ISSPACE_/g; s/(?<![A-Za-z0-9_])EVUTIL_ISUPPER(?![A-Za-z0-9_])/EVUTIL_ISUPPER_/g; s/(?<![A-Za-z0-9_])EVUTIL_ISXDIGIT(?![A-Za-z0-9_])/EVUTIL_ISXDIGIT_/g; s/(?<![A-Za-z0-9_])evutil_load_windows_system_library(?![A-Za-z0-9_])/evutil_load_windows_system_library_/g; s/(?<![A-Za-z0-9_])evutil_make_internal_pipe(?![A-Za-z0-9_])/evutil_make_internal_pipe_/g; s/(?<![A-Za-z0-9_])evutil_new_addrinfo(?![A-Za-z0-9_])/evutil_new_addrinfo_/g; s/(?<![A-Za-z0-9_])evutil_open_closeonexec(?![A-Za-z0-9_])/evutil_open_closeonexec_/g; s/(?<![A-Za-z0-9_])evutil_read_file(?![A-Za-z0-9_])/evutil_read_file_/g; s/(?<![A-Za-z0-9_])evutil_resolve(?![A-Za-z0-9_])/evutil_resolve_/g; s/(?<![A-Za-z0-9_])evutil_set_evdns_getaddrinfo_fn(?![A-Za-z0-9_])/evutil_set_evdns_getaddrinfo_fn_/g; s/(?<![A-Za-z0-9_])evutil_sockaddr_is_loopback(?![A-Za-z0-9_])/evutil_sockaddr_is_loopback_/g; s/(?<![A-Za-z0-9_])evutil_socket(?![A-Za-z0-9_])/evutil_socket_/g; s/(?<![A-Za-z0-9_])evutil_socket_connect(?![A-Za-z0-9_])/evutil_socket_connect_/g; s/(?<![A-Za-z0-9_])evutil_socket_finished_connecting(?![A-Za-z0-9_])/evutil_socket_finished_connecting_/g; s/(?<![A-Za-z0-9_])EVUTIL_TOLOWER(?![A-Za-z0-9_])/EVUTIL_TOLOWER_/g; s/(?<![A-Za-z0-9_])EVUTIL_TOUPPER(?![A-Za-z0-9_])/EVUTIL_TOUPPER_/g; s/(?<![A-Za-z0-9_])evutil_tv_to_msec(?![A-Za-z0-9_])/evutil_tv_to_msec_/g; s/(?<![A-Za-z0-9_])evutil_usleep(?![A-Za-z0-9_])/evutil_usleep_/g; s/(?<![A-Za-z0-9_])ht_improve_hash(?![A-Za-z0-9_])/ht_improve_hash_/g; s/(?<![A-Za-z0-9_])ht_string_hash(?![A-Za-z0-9_])/ht_string_hash_/g; s/(?<![A-Za-z0-9_])min_heap_adjust(?![A-Za-z0-9_])/min_heap_adjust_/g; s/(?<![A-Za-z0-9_])min_heap_ctor(?![A-Za-z0-9_])/min_heap_ctor_/g; s/(?<![A-Za-z0-9_])min_heap_dtor(?![A-Za-z0-9_])/min_heap_dtor_/g; s/(?<![A-Za-z0-9_])min_heap_elem_init(?![A-Za-z0-9_])/min_heap_elem_init_/g; s/(?<![A-Za-z0-9_])min_heap_elt_is_top(?![A-Za-z0-9_])/min_heap_elt_is_top_/g; s/(?<![A-Za-z0-9_])min_heap_empty(?![A-Za-z0-9_])/min_heap_empty_/g; s/(?<![A-Za-z0-9_])min_heap_erase(?![A-Za-z0-9_])/min_heap_erase_/g; s/(?<![A-Za-z0-9_])min_heap_pop(?![A-Za-z0-9_])/min_heap_pop_/g; s/(?<![A-Za-z0-9_])min_heap_push(?![A-Za-z0-9_])/min_heap_push_/g; s/(?<![A-Za-z0-9_])min_heap_reserve(?![A-Za-z0-9_])/min_heap_reserve_/g; s/(?<![A-Za-z0-9_])min_heap_size(?![A-Za-z0-9_])/min_heap_size_/g; s/(?<![A-Za-z0-9_])min_heap_top(?![A-Za-z0-9_])/min_heap_top_/g;
1 parent c963534 commit 8ac3c4c

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

53 files changed

+730
-730
lines changed

arc4random.c

+4-4
Original file line numberDiff line numberDiff line change
@@ -261,7 +261,7 @@ arc4_seed_proc_sys_kernel_random_uuid(void)
261261
unsigned char entropy[64];
262262
int bytes, n, i, nybbles;
263263
for (bytes = 0; bytes<ADD_ENTROPY; ) {
264-
fd = evutil_open_closeonexec("/proc/sys/kernel/random/uuid", O_RDONLY, 0);
264+
fd = evutil_open_closeonexec_("/proc/sys/kernel/random/uuid", O_RDONLY, 0);
265265
if (fd < 0)
266266
return -1;
267267
n = read(fd, buf, sizeof(buf));
@@ -270,8 +270,8 @@ arc4_seed_proc_sys_kernel_random_uuid(void)
270270
return -1;
271271
memset(entropy, 0, sizeof(entropy));
272272
for (i=nybbles=0; i<n; ++i) {
273-
if (EVUTIL_ISXDIGIT(buf[i])) {
274-
int nyb = evutil_hex_char_to_int(buf[i]);
273+
if (EVUTIL_ISXDIGIT_(buf[i])) {
274+
int nyb = evutil_hex_char_to_int_(buf[i]);
275275
if (nybbles & 1) {
276276
entropy[nybbles/2] |= nyb;
277277
} else {
@@ -305,7 +305,7 @@ arc4_seed_urandom(void)
305305
size_t n;
306306

307307
for (i = 0; filenames[i]; ++i) {
308-
fd = evutil_open_closeonexec(filenames[i], O_RDONLY, 0);
308+
fd = evutil_open_closeonexec_(filenames[i], O_RDONLY, 0);
309309
if (fd<0)
310310
continue;
311311
n = read_all(fd, buf, sizeof(buf));

buffer.c

+23-23
Original file line numberDiff line numberDiff line change
@@ -402,9 +402,9 @@ int
402402
evbuffer_defer_callbacks(struct evbuffer *buffer, struct event_base *base)
403403
{
404404
EVBUFFER_LOCK(buffer);
405-
buffer->cb_queue = event_base_get_deferred_cb_queue(base);
405+
buffer->cb_queue = event_base_get_deferred_cb_queue_(base);
406406
buffer->deferred_cbs = 1;
407-
event_deferred_cb_init(&buffer->deferred,
407+
event_deferred_cb_init_(&buffer->deferred,
408408
evbuffer_deferred_callback, buffer);
409409
EVBUFFER_UNLOCK(buffer);
410410
return 0;
@@ -435,7 +435,7 @@ evbuffer_enable_locking(struct evbuffer *buf, void *lock)
435435
}
436436

437437
void
438-
evbuffer_set_parent(struct evbuffer *buf, struct bufferevent *bev)
438+
evbuffer_set_parent_(struct evbuffer *buf, struct bufferevent *bev)
439439
{
440440
EVBUFFER_LOCK(buf);
441441
buf->parent = bev;
@@ -501,7 +501,7 @@ evbuffer_run_callbacks(struct evbuffer *buffer, int running_deferred)
501501
}
502502

503503
void
504-
evbuffer_invoke_callbacks(struct evbuffer *buffer)
504+
evbuffer_invoke_callbacks_(struct evbuffer *buffer)
505505
{
506506
if (LIST_EMPTY(&buffer->callbacks)) {
507507
buffer->n_add_for_cb = buffer->n_del_for_cb = 0;
@@ -513,9 +513,9 @@ evbuffer_invoke_callbacks(struct evbuffer *buffer)
513513
return;
514514
evbuffer_incref_and_lock_(buffer);
515515
if (buffer->parent)
516-
bufferevent_incref(buffer->parent);
516+
bufferevent_incref_(buffer->parent);
517517
EVBUFFER_UNLOCK(buffer);
518-
event_deferred_cb_schedule(buffer->cb_queue, &buffer->deferred);
518+
event_deferred_cb_schedule_(buffer->cb_queue, &buffer->deferred);
519519
}
520520

521521
evbuffer_run_callbacks(buffer, 0);
@@ -534,7 +534,7 @@ evbuffer_deferred_callback(struct deferred_cb *cb, void *arg)
534534
evbuffer_run_callbacks(buffer, 1);
535535
evbuffer_decref_and_unlock_(buffer);
536536
if (parent)
537-
bufferevent_decref(parent);
537+
bufferevent_decref_(parent);
538538
}
539539

540540
static void
@@ -567,7 +567,7 @@ evbuffer_decref_and_unlock_(struct evbuffer *buffer)
567567
}
568568
evbuffer_remove_all_callbacks(buffer);
569569
if (buffer->deferred_cbs)
570-
event_deferred_cb_cancel(buffer->cb_queue, &buffer->deferred);
570+
event_deferred_cb_cancel_(buffer->cb_queue, &buffer->deferred);
571571

572572
EVBUFFER_UNLOCK(buffer);
573573
if (buffer->own_lock)
@@ -770,7 +770,7 @@ evbuffer_commit_space(struct evbuffer *buf,
770770
buf->total_len += added;
771771
buf->n_add_for_cb += added;
772772
result = 0;
773-
evbuffer_invoke_callbacks(buf);
773+
evbuffer_invoke_callbacks_(buf);
774774

775775
done:
776776
EVBUFFER_UNLOCK(buf);
@@ -982,8 +982,8 @@ evbuffer_add_buffer(struct evbuffer *outbuf, struct evbuffer *inbuf)
982982
inbuf->n_del_for_cb += in_total_len;
983983
outbuf->n_add_for_cb += in_total_len;
984984

985-
evbuffer_invoke_callbacks(inbuf);
986-
evbuffer_invoke_callbacks(outbuf);
985+
evbuffer_invoke_callbacks_(inbuf);
986+
evbuffer_invoke_callbacks_(outbuf);
987987

988988
done:
989989
EVBUFFER_UNLOCK2(inbuf, outbuf);
@@ -1026,7 +1026,7 @@ evbuffer_add_buffer_reference(struct evbuffer *outbuf, struct evbuffer *inbuf)
10261026
APPEND_CHAIN_MULTICAST(outbuf, inbuf);
10271027

10281028
outbuf->n_add_for_cb += in_total_len;
1029-
evbuffer_invoke_callbacks(outbuf);
1029+
evbuffer_invoke_callbacks_(outbuf);
10301030

10311031
done:
10321032
EVBUFFER_UNLOCK2(inbuf, outbuf);
@@ -1072,8 +1072,8 @@ evbuffer_prepend_buffer(struct evbuffer *outbuf, struct evbuffer *inbuf)
10721072
inbuf->n_del_for_cb += in_total_len;
10731073
outbuf->n_add_for_cb += in_total_len;
10741074

1075-
evbuffer_invoke_callbacks(inbuf);
1076-
evbuffer_invoke_callbacks(outbuf);
1075+
evbuffer_invoke_callbacks_(inbuf);
1076+
evbuffer_invoke_callbacks_(outbuf);
10771077
done:
10781078
EVBUFFER_UNLOCK2(inbuf, outbuf);
10791079
return result;
@@ -1139,7 +1139,7 @@ evbuffer_drain(struct evbuffer *buf, size_t len)
11391139

11401140
buf->n_del_for_cb += len;
11411141
/* Tell someone about changes in this buffer */
1142-
evbuffer_invoke_callbacks(buf);
1142+
evbuffer_invoke_callbacks_(buf);
11431143

11441144
done:
11451145
EVBUFFER_UNLOCK(buf);
@@ -1311,8 +1311,8 @@ evbuffer_remove_buffer(struct evbuffer *src, struct evbuffer *dst,
13111311
src->n_del_for_cb += nread;
13121312

13131313
if (nread) {
1314-
evbuffer_invoke_callbacks(dst);
1315-
evbuffer_invoke_callbacks(src);
1314+
evbuffer_invoke_callbacks_(dst);
1315+
evbuffer_invoke_callbacks_(src);
13161316
}
13171317
result = (int)nread;/*XXXX should change return type */
13181318

@@ -1778,7 +1778,7 @@ evbuffer_add(struct evbuffer *buf, const void *data_in, size_t datlen)
17781778
buf->n_add_for_cb += datlen;
17791779

17801780
out:
1781-
evbuffer_invoke_callbacks(buf);
1781+
evbuffer_invoke_callbacks_(buf);
17821782
result = 0;
17831783
done:
17841784
EVBUFFER_UNLOCK(buf);
@@ -1852,7 +1852,7 @@ evbuffer_prepend(struct evbuffer *buf, const void *data, size_t datlen)
18521852
buf->n_add_for_cb += (size_t)chain->misalign;
18531853

18541854
out:
1855-
evbuffer_invoke_callbacks(buf);
1855+
evbuffer_invoke_callbacks_(buf);
18561856
result = 0;
18571857
done:
18581858
EVBUFFER_UNLOCK(buf);
@@ -2341,7 +2341,7 @@ evbuffer_read(struct evbuffer *buf, evutil_socket_t fd, int howmuch)
23412341
buf->n_add_for_cb += n;
23422342

23432343
/* Tell someone about changes in this buffer */
2344-
evbuffer_invoke_callbacks(buf);
2344+
evbuffer_invoke_callbacks_(buf);
23452345
result = n;
23462346
done:
23472347
EVBUFFER_UNLOCK(buf);
@@ -2807,7 +2807,7 @@ evbuffer_add_vprintf(struct evbuffer *buf, const char *fmt, va_list ap)
28072807
buf->n_add_for_cb += sz;
28082808

28092809
advance_last_with_data(buf);
2810-
evbuffer_invoke_callbacks(buf);
2810+
evbuffer_invoke_callbacks_(buf);
28112811
result = sz;
28122812
goto done;
28132813
}
@@ -2865,7 +2865,7 @@ evbuffer_add_reference(struct evbuffer *outbuf,
28652865
evbuffer_chain_insert(outbuf, chain);
28662866
outbuf->n_add_for_cb += datlen;
28672867

2868-
evbuffer_invoke_callbacks(outbuf);
2868+
evbuffer_invoke_callbacks_(outbuf);
28692869

28702870
result = 0;
28712871
done:
@@ -3159,7 +3159,7 @@ evbuffer_add_file_segment(struct evbuffer *buf,
31593159
buf->n_add_for_cb += length;
31603160
evbuffer_chain_insert(buf, chain);
31613161

3162-
evbuffer_invoke_callbacks(buf);
3162+
evbuffer_invoke_callbacks_(buf);
31633163

31643164
EVBUFFER_UNLOCK(buf);
31653165

buffer_iocp.c

+6-6
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ pin_release(struct evbuffer_overlapped *eo, unsigned flag)
9494
}
9595

9696
void
97-
evbuffer_commit_read(struct evbuffer *evbuf, ev_ssize_t nBytes)
97+
evbuffer_commit_read_(struct evbuffer *evbuf, ev_ssize_t nBytes)
9898
{
9999
struct evbuffer_overlapped *buf = upcast_evbuffer(evbuf);
100100
struct evbuffer_chain **chainp;
@@ -129,13 +129,13 @@ evbuffer_commit_read(struct evbuffer *evbuf, ev_ssize_t nBytes)
129129
evbuf->total_len += nBytes;
130130
evbuf->n_add_for_cb += nBytes;
131131

132-
evbuffer_invoke_callbacks(evbuf);
132+
evbuffer_invoke_callbacks_(evbuf);
133133

134134
evbuffer_decref_and_unlock_(evbuf);
135135
}
136136

137137
void
138-
evbuffer_commit_write(struct evbuffer *evbuf, ev_ssize_t nBytes)
138+
evbuffer_commit_write_(struct evbuffer *evbuf, ev_ssize_t nBytes)
139139
{
140140
struct evbuffer_overlapped *buf = upcast_evbuffer(evbuf);
141141

@@ -149,7 +149,7 @@ evbuffer_commit_write(struct evbuffer *evbuf, ev_ssize_t nBytes)
149149
}
150150

151151
struct evbuffer *
152-
evbuffer_overlapped_new(evutil_socket_t fd)
152+
evbuffer_overlapped_new_(evutil_socket_t fd)
153153
{
154154
struct evbuffer_overlapped *evo;
155155

@@ -168,7 +168,7 @@ evbuffer_overlapped_new(evutil_socket_t fd)
168168
}
169169

170170
int
171-
evbuffer_launch_write(struct evbuffer *buf, ev_ssize_t at_most,
171+
evbuffer_launch_write_(struct evbuffer *buf, ev_ssize_t at_most,
172172
struct event_overlapped *ol)
173173
{
174174
struct evbuffer_overlapped *buf_o = upcast_evbuffer(buf);
@@ -242,7 +242,7 @@ evbuffer_launch_write(struct evbuffer *buf, ev_ssize_t at_most,
242242
}
243243

244244
int
245-
evbuffer_launch_read(struct evbuffer *buf, size_t at_most,
245+
evbuffer_launch_read_(struct evbuffer *buf, size_t at_most,
246246
struct event_overlapped *ol)
247247
{
248248
struct evbuffer_overlapped *buf_o = upcast_evbuffer(buf);

bufferevent-internal.h

+12-12
Original file line numberDiff line numberDiff line change
@@ -279,52 +279,52 @@ extern const struct bufferevent_ops bufferevent_ops_async;
279279
#endif
280280

281281
/** Initialize the shared parts of a bufferevent. */
282-
int bufferevent_init_common(struct bufferevent_private *, struct event_base *, const struct bufferevent_ops *, enum bufferevent_options options);
282+
int bufferevent_init_common_(struct bufferevent_private *, struct event_base *, const struct bufferevent_ops *, enum bufferevent_options options);
283283

284284
/** For internal use: temporarily stop all reads on bufev, until the conditions
285285
* in 'what' are over. */
286-
void bufferevent_suspend_read(struct bufferevent *bufev, bufferevent_suspend_flags what);
286+
void bufferevent_suspend_read_(struct bufferevent *bufev, bufferevent_suspend_flags what);
287287
/** For internal use: clear the conditions 'what' on bufev, and re-enable
288288
* reading if there are no conditions left. */
289-
void bufferevent_unsuspend_read(struct bufferevent *bufev, bufferevent_suspend_flags what);
289+
void bufferevent_unsuspend_read_(struct bufferevent *bufev, bufferevent_suspend_flags what);
290290

291291
/** For internal use: temporarily stop all writes on bufev, until the conditions
292292
* in 'what' are over. */
293-
void bufferevent_suspend_write(struct bufferevent *bufev, bufferevent_suspend_flags what);
293+
void bufferevent_suspend_write_(struct bufferevent *bufev, bufferevent_suspend_flags what);
294294
/** For internal use: clear the conditions 'what' on bufev, and re-enable
295295
* writing if there are no conditions left. */
296-
void bufferevent_unsuspend_write(struct bufferevent *bufev, bufferevent_suspend_flags what);
296+
void bufferevent_unsuspend_write_(struct bufferevent *bufev, bufferevent_suspend_flags what);
297297

298298
#define bufferevent_wm_suspend_read(b) \
299-
bufferevent_suspend_read((b), BEV_SUSPEND_WM)
299+
bufferevent_suspend_read_((b), BEV_SUSPEND_WM)
300300
#define bufferevent_wm_unsuspend_read(b) \
301-
bufferevent_unsuspend_read((b), BEV_SUSPEND_WM)
301+
bufferevent_unsuspend_read_((b), BEV_SUSPEND_WM)
302302

303303
/*
304304
Disable a bufferevent. Equivalent to bufferevent_disable(), but
305305
first resets 'connecting' flag to force EV_WRITE down for sure.
306306
307307
XXXX this method will go away in the future; try not to add new users.
308-
See comment in evhttp_connection_reset() for discussion.
308+
See comment in evhttp_connection_reset_() for discussion.
309309
310310
@param bufev the bufferevent to be disabled
311311
@param event any combination of EV_READ | EV_WRITE.
312312
@return 0 if successful, or -1 if an error occurred
313313
@see bufferevent_disable()
314314
*/
315-
int bufferevent_disable_hard(struct bufferevent *bufev, short event);
315+
int bufferevent_disable_hard_(struct bufferevent *bufev, short event);
316316

317317
/** Internal: Set up locking on a bufferevent. If lock is set, use it.
318318
* Otherwise, use a new lock. */
319-
int bufferevent_enable_locking(struct bufferevent *bufev, void *lock);
319+
int bufferevent_enable_locking_(struct bufferevent *bufev, void *lock);
320320
/** Internal: Increment the reference count on bufev. */
321-
void bufferevent_incref(struct bufferevent *bufev);
321+
void bufferevent_incref_(struct bufferevent *bufev);
322322
/** Internal: Lock bufev and increase its reference count.
323323
* unlocking it otherwise. */
324324
void bufferevent_incref_and_lock_(struct bufferevent *bufev);
325325
/** Internal: Decrement the reference count on bufev. Returns 1 if it freed
326326
* the bufferevent.*/
327-
int bufferevent_decref(struct bufferevent *bufev);
327+
int bufferevent_decref_(struct bufferevent *bufev);
328328
/** Internal: Drop the reference count on bufev, freeing as necessary, and
329329
* unlocking it otherwise. Returns 1 if it freed the bufferevent. */
330330
int bufferevent_decref_and_unlock_(struct bufferevent *bufev);

0 commit comments

Comments
 (0)