Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an error logging client interceptor to gRPC clients #1786

Open
2 tasks
SanjayVas opened this issue Aug 29, 2024 · 0 comments
Open
2 tasks

Add an error logging client interceptor to gRPC clients #1786

SanjayVas opened this issue Aug 29, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@SanjayVas
Copy link
Member

This came up when trying to debug #1785. We have ErrorLoggingServerInterceptor installed on gRPC servers when verbose debug logging is disabled to ensure we have logs for unexpected errors. For gRPC clients however we have no such interceptor, meaning we will not have logs with trace IDs.

  • Implement ErrorLoggingClientInterceptor
  • Install ErrorLoggingClientInterceptor in gRPC clients when verbose debug logging is not enabled
@SanjayVas SanjayVas added the enhancement New feature or request label Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@SanjayVas