Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid failing Measurements at Duchy due to stale ComputationParticipant state #1663

Closed
SanjayVas opened this issue Jun 13, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@SanjayVas
Copy link
Member

Scenario:

  1. Herald sees a Measurement update that tells it to set participant requisition params. It enqueues that task.
  2. Mill calls SetParticipantRequisitionParams at Kingdom and succeeds.
  3. Mill crashes before completing the write to local DB.

The current behavior is that the Mill will pick up the transient failed task for retry and call SetParticipantRequisitionParams again, failing due to the ComputationParticipant state already having transitioned.

This case need not result in a Measurement failure. There are also similar cases for other ComputationParticipant mutations.

See #1645 for more details.

@SanjayVas SanjayVas self-assigned this Jun 13, 2024
@SanjayVas SanjayVas added the enhancement New feature or request label Jun 13, 2024
@SanjayVas
Copy link
Member Author

Closed by #1665

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant