414 - Removes existing console logs, rename them to error or disable the rule locally (resulting in a passing build)

Author: ricardovdheijden

apps/wfo-ui-surf/components/WfoServiceTicketDetailPage/WfoSubscriptionImpactTable.tsx

@@ -48,8 +48,6 @@ export const WfoSubscriptionImpactTable = () => {
     const toggleDetails = (object: ServiceTicketImpactedObjectColumns) => {
         const itemIdToExpandedRowMapValues = { ...itemIdToExpandedRowMap };
         const id = object.subscription_id ? object.subscription_id : '0';
-        console.log(itemIdToExpandedRowMapValues, 'toggleDetails');
-        console.log(object, 'object');
 
         if (itemIdToExpandedRowMapValues[id]) {
             delete itemIdToExpandedRowMapValues[id];
@@ -85,11 +83,6 @@ export const WfoSubscriptionImpactTable = () => {
                     const itemIdToExpandedRowMapValues = {
                         ...itemIdToExpandedRowMap,
                     };
-                    console.log('OBJECT', object);
-                    console.log(
-                        itemIdToExpandedRowMapValues,
-                        'itemIdToExpandedRowMapValues',
-                    );
                     return value ? (
                         <EuiButtonIcon
                             onClick={() => toggleDetails(object)}

apps/wfo-ui-surf/pages/forms.tsx

@@ -6,6 +6,7 @@ import { CreateForm } from '@orchestrator-ui/orchestrator-ui-components';
 export function FormsPage() {
     /* eslint-disable  @typescript-eslint/no-explicit-any */
     const handleSubmit = (userInputs: any) => {
+        // eslint-disable-next-line no-console
         console.log('Submitted: ', userInputs);
     };
 

apps/wfo-ui/pages/forms.tsx

@@ -6,6 +6,7 @@ import { CreateForm } from '@orchestrator-ui/orchestrator-ui-components';
 export function FormsPage() {
     /* eslint-disable  @typescript-eslint/no-explicit-any */
     const handleSubmit = (userInputs: any) => {
+        // eslint-disable-next-line no-console
         console.log('Submitted: ', userInputs);
     };
 

packages/orchestrator-ui-components/src/api/index.ts

@@ -47,9 +47,6 @@ export class BaseApiClient {
             .then((res) => res.data)
             .catch((err) => {
                 if (showErrorDialog) {
-                    console.debug(
-                        `Show error dialog for GET ${path} returning ${err?.response?.status}`,
-                    );
                     setTimeout(() => {
                         throw err;
                     }, 250);

packages/orchestrator-ui-components/src/components/WfoForms/CreateForm.tsx

@@ -34,7 +34,6 @@ export function CreateForm(props: IProps) {
     const submit = useCallback(
         (userInputs: object[]) => {
             return apiClient.cimStartForm(formKey, userInputs).then((form) => {
-                console.log('Submit {formkey} =', formKey);
                 handleSubmit(form);
             });
         },

packages/orchestrator-ui-components/src/components/WfoForms/UserInputForm.tsx

@@ -448,6 +448,7 @@ function UserInputForm({
         question: string | undefined,
         confirm: ConfirmDialogActions['closeConfirmDialog'],
     ) => {
+        // eslint-disable-next-line no-console
         console.log(e, question, confirm);
         alert('TODO: Implement on buttonClick cancel with confirm modal');
         // https://github.com/workfloworchestrator/orchestrator-ui/issues/325

packages/orchestrator-ui-components/src/components/WfoForms/formFields/IpPrefixTableField.tsx

@@ -123,7 +123,7 @@ export default class IpPrefixTableField extends React.PureComponent<IProps> {
                     ? aVal.toLowerCase().localeCompare(bVal.toLowerCase())
                     : (aVal as number) - (bVal as number);
             } catch (e) {
-                console.log(e);
+                console.error(e);
             }
             return 0;
         };

packages/orchestrator-ui-components/src/components/WfoWorkflowSteps/WfoStepList/WfoStepList.tsx

@@ -61,7 +61,10 @@ export const WfoStepList = React.forwardRef(
                         behavior: 'smooth',
                     });
                 } catch {
-                    console.log('Error scrolling to step with stepId ', stepId);
+                    console.error(
+                        'Error scrolling to step with stepId ',
+                        stepId,
+                    );
                 }
             },
         }));

packages/orchestrator-ui-components/src/pages/workflow/WfoStartWorkflowPage.tsx

@@ -72,6 +72,7 @@ export const WfoStartWorkflowPage = ({
                         const process = result as { id: string };
                         // TODO: Use toast hook to display success message
                         if (process.id) {
+                            // eslint-disable-next-line no-console
                             console.log(
                                 'resolver successfullly!: ',
                                 process.id,
@@ -92,7 +93,7 @@ export const WfoStartWorkflowPage = ({
                 503,
                 (json) => {
                     // TODO: Use the toastMessage hook to display an engine down error message
-                    console.log('engine down!!!', json);
+                    console.error('engine down!!!', json);
                     router.push(PATH_PROCESSES);
                 },
             );