723: Fix SummaryField .includes is not a function (#748)

tjeerddie · web-flow · commit 2310074c0509 · 2024-02-06T12:13:34.000+01:00
* Fix SummaryField .includes is not a function

- check if row is string before trying .includes.

* Change incorrect default customerKey in ContactPersonName field

* Add changeset
diff --git a/.changeset/smooth-walls-laugh.md b/.changeset/smooth-walls-laugh.md
@@ -0,0 +1,5 @@
+---
+"@orchestrator-ui/orchestrator-ui-components": patch
+---
+
+723: Fix SummaryField .includes is not a function
diff --git a/packages/orchestrator-ui-components/src/components/WfoForms/formFields/ContactPersonNameField.tsx b/packages/orchestrator-ui-components/src/components/WfoForms/formFields/ContactPersonNameField.tsx
@@ -89,21 +89,21 @@ function ContactPersonName({
         : name;
     const contactsField = useField(useFieldName, {}, { absoluteName: true })[0];
 
-    const customerFieldName =
-        customerKey || contactsField.field.customerKey || 'customer';
+    const customerIdFieldName =
+        customerKey || contactsField.field.customerKey || 'customer_id';
 
     // Get initial value for org field if it exists (we cant really test)
     let customerInitialValue;
     try {
-        customerInitialValue = schema.getInitialValue(customerFieldName, {});
+        customerInitialValue = schema.getInitialValue(customerIdFieldName, {});
     } catch {
         customerInitialValue = '';
     }
 
     const customerIdValue =
         customerId ||
         contactsField.field.customerId ||
-        get(model, customerFieldName, customerInitialValue);
+        get(model, customerIdFieldName, customerInitialValue);
 
     const [displayAutocomplete, setDisplayAutocomplete] = useState(false);
     const [contactPersons, setContactPersons] = useState<ContactPerson[]>([]);
diff --git a/packages/orchestrator-ui-components/src/components/WfoForms/formFields/SummaryField.tsx b/packages/orchestrator-ui-components/src/components/WfoForms/formFields/SummaryField.tsx
@@ -46,12 +46,11 @@ function Summary({
     const { headers, labels, columns } = data;
 
     const extraColumnsData = columns.filter((_, index) => index !== 0);
-
     const rows = columns[0].map((row, index) => (
         <tr key={index}>
             {labels && <td className={`label`}>{labels[index]}</td>}
             <td className={`value`}>
-                {row.includes('<!doctype html>') ? (
+                {typeof row === 'string' && row.includes('<!doctype html>') ? (
                     <div
                         className="emailMessage"
                         dangerouslySetInnerHTML={{ __html: row }}

-Original file line number
+Diff line change
@@ @@ -0,0 +1,5 @@ @@
 +---
 +"@orchestrator-ui/orchestrator-ui-components": patch
 +---
++
 +723: Fix SummaryField .includes is not a function