Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Classname to style conversion isn't working #320

Closed
marecar3 opened this issue Dec 4, 2018 · 1 comment
Closed

Classname to style conversion isn't working #320

marecar3 opened this issue Dec 4, 2018 · 1 comment
Assignees
@Tug
Labels
[Type] Bug Something isn't working
Milestone
Alpha

Comments

@marecar3
Copy link
Contributor

marecar3 commented Dec 4, 2018 •
edited
Loading

It seems that after this PR classname to style conversion isn't working anymore.

Side effects can be seen on Format Toolbar, where all buttons have black color in both active and inactive state.
@marecar3 marecar3 changed the title Revert react-native-classname-to-style plugin Revert removed react-native-classname-to-style plugin Dec 4, 2018
@marecar3 marecar3 added the [Type] Bug Something isn't working label Dec 4, 2018
@marecar3 marecar3 added this to the Alpha milestone Dec 4, 2018
@marecar3 marecar3 changed the title Revert removed react-native-classname-to-style plugin Classname to style conversion isn't working Dec 4, 2018
@Tug
Copy link
Contributor

Tug commented Dec 5, 2018

Investigating.
I bet we can find other ways to have those styles back in our UI, the classname-to-style transform applies also to the save() method which creates invalid html when serialization occurs.

This was referenced Dec 5, 2018
Merged
Merged
@Tug Tug closed this as completed in #322 Dec 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tug Tug

Labels
[Type] Bug Something isn't working
Projects
None yet
Milestone
Alpha
Development

No branches or pull requests
2 participants
@Tug @marecar3