Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global Style System - Block level support #2147

Closed
pinarol opened this issue Apr 9, 2020 · 0 comments
Closed

Global Style System - Block level support #2147

pinarol opened this issue Apr 9, 2020 · 0 comments
Assignees
Labels
[Type] Enhancement Improves a current area of the editor

Comments

@pinarol
Copy link
Contributor

pinarol commented Apr 9, 2020

This issue still needs analysis & discussions but we need to start from somewhere :) The purpose of this issue is first of all figuring out what needs to be done on mobile side to support GSS on "block level".

Background

Global Style System <<-- master issue. At the end, we’ll need a mechanism on mobile side to propagate down the styles from top level to component level while considering the priorities at each level. Theme (global) > User (edited global styles) > Specific styles per post > specific styles per block.

What's implemented so far on web is the last level of priority (block level specific style) in some blocks for colors and line-height. +experimental support for the theme level styles (theme.json file)

Related web PRs:

Introduce a support key for support global style colors in blocks
WordPress/gutenberg#21021
Use inline styles instead of CSS variables for the style attribute:
WordPress/gutenberg#21428

Updating some blocks using the colors support key:
WordPress/gutenberg#21037
WordPress/gutenberg#21038
WordPress/gutenberg#21039
WordPress/gutenberg#21169

Gradients:
WordPress/gutenberg#21375
WordPress/gutenberg#21481

Apply the custom global styles CSS variables on the server:
WordPress/gutenberg#21420

What has been done so far on mobile side?

Merged Add color hooks for the mobile implementation

What else needs to be done on mobile?

  1. We know we need to make getEditWrapperProps work on mobile

This is the follow up work for this convo: WordPress/gutenberg#21257 (comment)

  1. Discuss&Analyze what else needs to be done to support "block level specific style(last level of priority)" on mobile.

cc @Tug @maxme @hypest @SergioEstevao

@pinarol pinarol added the [Type] Enhancement Improves a current area of the editor label Apr 9, 2020
@dratwas dratwas mentioned this issue Apr 28, 2020
2 tasks
@pinarol pinarol closed this as completed May 4, 2020
@Tug Tug self-assigned this Sep 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Enhancement Improves a current area of the editor
Projects
None yet
Development

No branches or pull requests

3 participants