Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to change caret color in RichText #1773

Closed
lukewalczak opened this issue Jan 13, 2020 · 4 comments · Fixed by #1776
Closed

Add option to change caret color in RichText #1773

lukewalczak opened this issue Jan 13, 2020 · 4 comments · Fixed by #1776
Assignees
@SergioEstevao @chipsnyder
Labels
Mobile Request [Type] Enhancement Improves a current area of the editor

Comments

@lukewalczak
Copy link
Contributor

Is your feature request related to a problem? Please describe.

Currently there is no option to change a caret color in RichText component which causes a visibility issue when background color is blue-ish.

Screenshot 2020-01-13 at 13 14 33

Describe the solution you'd like

React Native TextInput has a prop called selectionColor which allows to change caret and selected text color. I think that's the way which we can follow.
@SergioEstevao SergioEstevao self-assigned this Jan 13, 2020
@SergioEstevao
Copy link
Contributor

I can tackle the iOS part of this issue.

@chipsnyder
Copy link
Contributor

I'm happy to take on the Android side.

@chipsnyder chipsnyder self-assigned this Jan 13, 2020
@pinarol
Copy link
Contributor

pinarol commented Jan 13, 2020

great thanks! @SergioEstevao @chipsnyder 🎉

@lukewalczak
Copy link
Contributor Author

Thank you both!

@SergioEstevao SergioEstevao mentioned this issue Jan 14, 2020
Merged
2 tasks
This was referenced Jan 15, 2020
Merged
Closed
@chipsnyder chipsnyder mentioned this issue May 17, 2021
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SergioEstevao SergioEstevao

@chipsnyder chipsnyder

Labels
Mobile Request [Type] Enhancement Improves a current area of the editor
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow configuration of selection/caret color on Aztec view. wordpress-mobile/gutenberg-mobile
4 participants
@SergioEstevao @chipsnyder @pinarol @lukewalczak