Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block Picker: Layout is messed up/not all blocks appear on screen after rotating device #1491

Closed
rachelmcr opened this issue Oct 24, 2019 · 2 comments
Labels
Beta Request [Type] Bug Something isn't working

Comments

@rachelmcr
Copy link
Member

If you open the block picker and then rotate the device, the block picker layout is messed up. Not all blocks appear on screen and there's no way to navigate to them. The only solution is to close the block picker and reopen it.

Steps to reproduce

  1. With the device in portrait mode, start a new post.
  2. Open the block picker.
  3. Rotate the device to landscape. Note that the blocks don't use the full width of the screen and not all blocks fit on screen.
  4. Close the block picker and reopen it.
  5. Rotate the device to portrait. Note that some blocks don't appear on screen.

In addition, rotating the device with the block picker open on Android makes the keyboard appear. This doesn't cause any issues once the keyboard is closed, but it does interfere with viewing/interacting with the block picker.

Screenshots

iOS - rotating portrait to landscape:

2019-10-24 08 51 28
2019-10-24 08 51 31

iOS - rotating landscape to portrait (8 blocks instead of 10):

Android - rotating portrait to landscape:

Screenshot_20191024-101938

Android - rotating landscape to portrait:

Tested on:

  • WordPress iOS 13.5.0.20191021, iPhone XS, iOS 13.1.4
  • WordPress Android alpha-192, moto e5 play, Android 8.1.0
@rachelmcr rachelmcr added the [Type] Bug Something isn't working label Oct 24, 2019
@hypest
Copy link
Contributor

hypest commented Oct 25, 2019

In addition, rotating the device with the block picker open on Android makes the keyboard appear. This doesn't cause any issues once the keyboard is closed, but it does interfere with viewing/interacting with the block picker.

I think that's covered in #1333

@designsimply
Copy link
Contributor

Fixed in #1495. Props @etoledom. 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Beta Request [Type] Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants