Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Long-press on inserter to show options for "add above" and "add below" #1433

Closed
iamthomasbishop opened this issue Oct 10, 2019 · 3 comments · Fixed by WordPress/gutenberg#18791 or #1835
Assignees
Labels
Proposal [Type] Enhancement Improves a current area of the editor

Comments

@iamthomasbishop
Copy link
Contributor

Long-pressing on the inserter button ((+) on the quick toolbar) should show options to Add Block Before and Add Block After the currently selected block. If there is no selection these options could be Add to beginning and Add to end. On iOS, this could be an ActionSheet and Android a BottomSheet.

Example:

IMG_0645

Note: I think we could expand on this pattern in the future, but I've found myself wanting to do add blocks before the selected one quite often, especially now that we have InnerBlocks.

We might also want to add these options to the ••• menu on the inline toolbar when we get a chance, similar to web.

@iamthomasbishop iamthomasbishop added [Type] Enhancement Improves a current area of the editor Proposal labels Oct 10, 2019
@hypest
Copy link
Contributor

hypest commented Nov 1, 2019

Aha, I'm not sure how discoverable the long-press will be but, let's go with the proposal, starting with the long-press alone.

The inline toolbar menu can be done in a separate step.

@iamthomasbishop
Copy link
Contributor Author

I'm not sure how discoverable the long-press will be

I have a feeling it'll be more expected than it seems on the surface (similar to the "empty space at the end of the post" expectation), but considering it's additive at this point, I think it's a good starting point. In the long-run maybe we have a bunch of options, here are a few:

  • Show a "floating tip" of sorts
  • Add as part of a more comprehensive on-boarding flow 
  • Trigger a "tip" after you insert your first block as an explainer

The inline toolbar menu can be done in a separate step.

Sounds good 👍 I was assuming we wouldn't work on that for a while (until we have that ••• menu).

@ceyhun
Copy link
Contributor

ceyhun commented Nov 19, 2019

Hello everyone, I'll be working on this 🛠

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment