[JDBC 구현하기 - 1단계] 도기(김동호) 미션 제출합니다. #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdkdhoho
changed the title
parkmuhyeun
approved these changes
Oct 1, 2023
Comment on lines
+67
to
+69
| do { | ||
| result.add(rowMapper.mapRow(resultSet)); | ||
| } while (resultSet.next()); |
There was a problem hiding this comment.
while (resultSet.next()) {
...
}
로 하면 밖에서의 If문도 제거하고 do while도 바꿀 수 있을거 같아요!
Comment on lines
+39
to
+42
| List<T> result = query(sql, rowMapper, params); | ||
| if (result.size() != 1) { | ||
| throw new DataAccessException("Result Count is Not Only 1. ResultCount=" + result.size()); | ||
| } |
There was a problem hiding this comment.
와우 query 재활용에다가 꼼꼼한 에러 처리까지 👍🏻👍🏻
There was a problem hiding this comment.
체스 미션땐가 query와 queryForObject의 차이에 대해 깊게 공부한 덕을 보네요 😆
| } | ||
|
|
||
| public <T> T queryForObject(final String sql, final RowMapper<T> rowMapper, final Object... params) { | ||
| List<T> result = query(sql, rowMapper, params); |
There was a problem hiding this comment.
final이 붙은 곳도 있고 안 붙은 곳도 있는거 같아서 전체적으로 통일시켜주면 더 좋을 것 같아요!
| import javax.sql.DataSource; | ||
| import java.sql.Connection; | ||
| import java.sql.PreparedStatement; | ||
| import java.sql.SQLException; | ||
|
|
||
| public class UserHistoryDao { |
There was a problem hiding this comment.
어.. 이거보니 생각났는데 저는 HistoryDao는 안 고쳐줬네요ㅋㅋㅋ
꼼꼼도기 👍🏻
| import java.sql.ResultSet; | ||
| import java.sql.SQLException; | ||
|
|
||
| @FunctionalInterface |
| } | ||
| } | ||
|
|
||
| private DatabasePopulatorUtils() {} | ||
| public static void clear(final DataSource dataSource) { |
There was a problem hiding this comment.
clear까지 구현해놓으셨군요 🚀
아래 코드에서 궁금한게 있어요. var을 적용하는 변수의 기준이 있는지 궁금합니다!
There was a problem hiding this comment.
사실 원래 var를 잘 적용하지 않는데요. 미션 코드에서 var를 사용하길래 통일성을 위해 사용했습니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
안녕하세요 무민! 만나서 반갑습니다 🙇♂️
추석 연휴는 잘 보내고 계신가요? 어제 달이 진짜 크던데 보셨는지 모르겠네요.
처음에 어디서부터 어디까지 구현해야할 지 감이 안와서 Oracle 공식문서 보고 감을 잡았습니다.
UserDaoTest의 경우도 제 입맛대로 단언문을 바꿔보았어요.
그에 따라 요구사항에는 존재하지 않지만 DB를 clean up 해주는 메서드도 구현하게 된 점 미리 말씀드립니다.
그럼 잘 부탁드립니다 👍