Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

인기게시물에서 isLike여부에 따라서 보여주는 UI를 변경한다. #896

Merged
merged 3 commits into from
Nov 8, 2022

Conversation

hwangstar156
Copy link
Collaborator

close #894

isLike를 통하여 누른경우만 차보이는 하트를 보여주도록 구현

  • Carousel에 대해 의도가 담긴 네이밍 추가

@hwangstar156 hwangstar156 added 🌈 frontend 프론트엔드 이슈 💫 feat 기능 구현 이슈 labels Nov 4, 2022
@hwangstar156 hwangstar156 self-assigned this Nov 4, 2022
Copy link
Collaborator

@liswktjs liswktjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

몇가지 수정사항 남겼습니다! 확인해주세요~

@hwangstar156 hwangstar156 changed the base branch from develop to main November 4, 2022 13:53
@hwangstar156 hwangstar156 requested a review from liswktjs November 4, 2022 14:02
Copy link
Collaborator

@liswktjs liswktjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

웹접근성 👍

@liswktjs liswktjs merged commit 9d1066b into main Nov 8, 2022
@liswktjs liswktjs deleted the fix/894 branch November 8, 2022 02:18
liswktjs added a commit that referenced this pull request Nov 10, 2022
* 이미지 리사이징이 되지 않는 문제 해결 (#879)

* Home이 로드 될 때에 바로 사용되지 않는 컴포넌트에 대해서 동적 import를 진행한다  (#882)

* fix: 바로 사용되지 않는 EmptyMessage component에 대해서 lazy loading 처리

* chore: 당장 사용하지 않는 ts-loader 제거

* 인기게시물에서 isLike여부에 따라서 보여주는 UI를 변경한다.  (#896)

* fix: Carousel 의도를 들어낼 수 있는 네이밍으로 수정

* fix: 하트를 누른 경우에만 차보이도록 구현

* feat: aria-label 추가

Co-authored-by: JASUN LEE <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💫 feat 기능 구현 이슈 🌈 frontend 프론트엔드 이슈
Projects
None yet
Development

Successfully merging this pull request may close these issues.

인기게시물에서 isLike여부에 따라서 보여주는 UI를 변경한다.
2 participants