Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

타입스크립트 컨벤션에 맞춰 리팩토링을 진행한다 #790

Open
liswktjs opened this issue Oct 18, 2022 · 0 comments · May be fixed by #870
Open

타입스크립트 컨벤션에 맞춰 리팩토링을 진행한다 #790

liswktjs opened this issue Oct 18, 2022 · 0 comments · May be fixed by #870
Assignees
@liswktjs
Labels
🌈 frontend 프론트엔드 이슈 ♻️ refactor 리팩터링 이슈 📝 typescript

Comments

@liswktjs
Copy link
Collaborator

liswktjs commented Oct 18, 2022 •
edited
Loading

리팩터링 하는 이유

혼재되어 있는 타입스크립트 컨벤션을 맞춰 코드에 적용한다

리팩터링 할 내용

  • api 폴더 밑에 api 비동기 통신 로직과 응답값 타입을 지정한다
  • 중복되는 타입의 경우 Omit 등의 타입을 활용하여 중복을 제거한다
  • axios 인스턴스를 통해 중복되는 선언을 제거한다

예상 시간
@liswktjs liswktjs added 🌈 frontend 프론트엔드 이슈 ♻️ refactor 리팩터링 이슈 📝 typescript labels Oct 18, 2022
@liswktjs liswktjs self-assigned this Oct 18, 2022
@liswktjs liswktjs linked a pull request Oct 24, 2022 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@liswktjs liswktjs

Labels
🌈 frontend 프론트엔드 이슈 ♻️ refactor 리팩터링 이슈 📝 typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

타입스크립트 컨벤션에 맞춰 리팩토링을 진행한다 woowacourse-teams/2022-gong-seek
1 participant
@liswktjs