Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to export/import outputs and image keys in raw format #54

Open
mahnunchik opened this issue May 4, 2021 · 3 comments
Open

Allow to export/import outputs and image keys in raw format #54

mahnunchik opened this issue May 4, 2021 · 3 comments
Labels
help wanted Extra attention is needed

Comments

@mahnunchik
Copy link

Allow to export/import outputs and image keys in raw (not encrypted) format.

@woodser
Copy link
Owner

woodser commented May 5, 2021

importKeyImages() and exportKeyImages() use an unencrypted format.

exportOutputs() returns a hex string to be used with importOutputs().
This functionality depends on monero-wallet-rpc so additional support would first need to be added there.

@mahnunchik
Copy link
Author

@woodser
Copy link
Owner

woodser commented May 9, 2021

My recommended approach is to rename MoneroWallet's exportOutputs() to exportOutputsStr() and add a new function, exportOutputs(), which returns a map from output offsets to MoneroOutputWallet like wallet2::export_outputs(). importOutputs() would accept either a string or the map.

Only MoneroWalletFull would support the functionality. MoneroWalletRpc would throw an unsupported error if exportOutputs() is invoked.

The implementation would be in monero-cpp's monero_wallet_full.cpp + the necessary bindings to JavaScript + tests.

@woodser woodser added the help wanted Extra attention is needed label May 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants