Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

startSyncing does not allow to save wallet until sync completes #207

Open
mainnet-pat opened this issue Apr 24, 2024 · 1 comment
Open

Comments

@mainnet-pat
Copy link
Contributor

If I install a listener for wallet sync and try to save the wallet periodically while it syncing (so that the sync process is not lost between browser page reloads) the call to save hangs indefinitely.

The very slow workaround here is to do:

            await wallet.stopSyncing();
            await wallet.save();
            await wallet.startSyncing(15000);
@woodser
Copy link
Owner

woodser commented Sep 17, 2024

await wallet.stopSyncing() calls down to wallet2->stop() immediately, which ought to stop the sync process as soon as possible:

this.module.stop_syncing(this.cppAddress); // task is not queued so wallet stops immediately

https://github.com/woodser/monero-cpp/blob/bdc0ee7666fc4ba4550501b24b3d2d49f54365cd/src/wallet/monero_wallet_full.cpp#L1568

So I'm surprised this is an issue, and not sure what else could be done unless one of my assumptions is wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants