Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: overprovisioned-secrets should also consider dynamic accesses #551

Open
2 tasks done
woodruffw opened this issue Feb 23, 2025 · 0 comments
Open
2 tasks done
Labels
enhancement New feature or request

Comments

@woodruffw
Copy link
Owner

Pre-submission checks

  • I am not reporting a bug (crash, false positive/negative, etc). These must be filed via the bug report template.
  • I have looked through the open issues for a duplicate request.

What's the problem this feature will solve?

Right now, overprovisioned-secrets detects patterns like toJSON(secrets).

However, another case that should be caught that results in overprovisioning is when secrets is indexed via a key that isn't known until workflow execution time, e.g.:

GH_TOKEN: ${{ secrets[format('GH_PAT_%s', matrix.env)] }}

poutine's job_all_secrets check has additional details: https://github.com/boostsecurityio/poutine/blob/main/docs/content/en/rules/job_all_secrets.md

Describe the solution you'd like

See above.

Additional context

No response

@woodruffw woodruffw added the enhancement New feature or request label Feb 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant