Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: "raw" audit support + overprovisioned-secrets #485

Merged
merged 10 commits into from
Jan 26, 2025
Merged

Conversation

woodruffw
Copy link
Owner

@woodruffw woodruffw commented Jan 23, 2025

WIP.

This will enable audits like #400 and #401.

Some open design questions:

1. How should we shoehorn this into SymbolicLocation/ConcreteLocation? In particular, how should we ensure that ignore comments are captured correctly?

Closes #401.

@woodruffw woodruffw added the enhancement New feature or request label Jan 23, 2025
@woodruffw woodruffw self-assigned this Jan 23, 2025
@woodruffw
Copy link
Owner Author

woodruffw commented Jan 23, 2025

The overprovisioned-secrets audit now works, although it doesn't support comment ignores yet. That's the last blocking piece here.

NTS: We should be able to get the comments by getting the line range from line-index with LineIndex::lines.

@woodruffw woodruffw added the new-audit New audits label Jan 23, 2025
@woodruffw woodruffw changed the title feat: "raw" audit support feat: "raw" audit support + overprovisioned-secrets Jan 23, 2025
@woodruffw woodruffw merged commit 312dce7 into main Jan 26, 2025
6 checks passed
@woodruffw woodruffw deleted the ww/audit-raw branch January 26, 2025 19:27
woodruffw added a commit that referenced this pull request Jan 26, 2025
woodruffw added a commit that referenced this pull request Jan 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request new-audit New audits
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New audit: excessive secret provisioning
1 participant