Skip to content

pipeline runtime: move setting step environment variables into own func and add CI_PIPELINE_STATUS back#6516

Merged
6543 merged 5 commits into
woodpecker-ci:mainfrom
6543-forks:pipeline-runtime_set-step-env-func
May 1, 2026
Merged

pipeline runtime: move setting step environment variables into own func and add CI_PIPELINE_STATUS back#6516
6543 merged 5 commits into
woodpecker-ci:mainfrom
6543-forks:pipeline-runtime_set-step-env-func

Conversation

@6543

@6543 6543 commented Apr 28, 2026

Copy link
Copy Markdown
Member

close #4337

@6543 6543 added enhancement improve existing features refactor delete or replace old code labels Apr 28, 2026
@6543 6543 added the blocked something external is blocking it label Apr 28, 2026
@6543

6543 commented Apr 28, 2026

Copy link
Copy Markdown
Member Author

note: blocked till release

@woodpecker-bot

woodpecker-bot commented Apr 28, 2026

Copy link
Copy Markdown
Contributor

Surge PR preview deployment was removed

@codecov

codecov Bot commented Apr 28, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 73.68421% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 41.20%. Comparing base (f3e3b83) to head (ef2abcc).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
pipeline/runtime/step.go 73.68% 3 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6516      +/-   ##
==========================================
- Coverage   41.20%   41.20%   -0.01%     
==========================================
  Files         431      431              
  Lines       28850    28855       +5     
==========================================
+ Hits        11887    11889       +2     
- Misses      15893    15895       +2     
- Partials     1070     1071       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@6543 6543 mentioned this pull request Apr 28, 2026
1 task
@qwerty287 qwerty287 changed the title pipeline runtime: move setting step environment bariables into own func and add CI_PIPELINE_STATUS back pipeline runtime: move setting step environment variables into own func and add CI_PIPELINE_STATUS back Apr 28, 2026
@6543 6543 removed the blocked something external is blocking it label May 1, 2026
@6543 6543 requested a review from a team May 1, 2026 10:48

@xoxys xoxys left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM but untested.

@6543 6543 merged commit 7cef7a8 into woodpecker-ci:main May 1, 2026
9 checks passed
@6543 6543 deleted the pipeline-runtime_set-step-env-func branch May 1, 2026 13:40
@woodpecker-bot woodpecker-bot mentioned this pull request May 1, 2026
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement improve existing features refactor delete or replace old code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow notification plugins to notify about the pipeline status

3 participants