Fix flaky TestJWTManager#6478
Merged
qwerty287 merged 2 commits intoApr 22, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6478 +/- ##
==========================================
+ Coverage 41.25% 41.29% +0.04%
==========================================
Files 431 431
Lines 28815 28815
==========================================
+ Hits 11887 11899 +12
+ Misses 15861 15850 -11
+ Partials 1067 1066 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
qwerty287
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test verified that a tampered JWT is rejected, but it was flipping the last base64url character of the signature instead of flipping an actual byte.
This was unreliable: the final character of a 32-byte HMAC-SHA256 signature only carries 4 meaningful bits. Go's base64 decoder silently ignores the other 2, so roughly 1 in 16 tokens decoded to the same bytes after the swap — meaning the "tampered" token passed verification and the test flaked.
Fix: decode the signature to raw bytes, XOR the first byte, then re-encode. This guarantees the signature bytes are actually different, making the test deterministic.
example: https://ci.woodpecker-ci.org/repos/3780/pipeline/33691/33