Skip to content

Add WOODPECKER_FORCE_IGNORE_SERVICE_FAILURE config to preserve non-breaking behavior by default#6448

Merged
6543 merged 6 commits into
woodpecker-ci:mainfrom
6543-forks:WOODPECKER_FORCE_IGNORE_SERVICE_FAILURE
Apr 17, 2026
Merged

Add WOODPECKER_FORCE_IGNORE_SERVICE_FAILURE config to preserve non-breaking behavior by default#6448
6543 merged 6 commits into
woodpecker-ci:mainfrom
6543-forks:WOODPECKER_FORCE_IGNORE_SERVICE_FAILURE

Conversation

@6543

@6543 6543 commented Apr 15, 2026

Copy link
Copy Markdown
Member

close #6372

@codecov

codecov Bot commented Apr 15, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 11.76471% with 15 lines in your changes missing coverage. Please review.
✅ Project coverage is 35.30%. Comparing base (4390796) to head (fa09886).

Files with missing lines Patch % Lines
cmd/server/setup.go 0.00% 5 Missing ⚠️
pipeline/frontend/yaml/compiler/option.go 0.00% 4 Missing ⚠️
pipeline/frontend/yaml/compiler/convert.go 0.00% 2 Missing and 1 partial ⚠️
server/pipeline/items.go 40.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6448      +/-   ##
==========================================
+ Coverage   35.28%   35.30%   +0.02%     
==========================================
  Files         431      431              
  Lines       28782    28798      +16     
==========================================
+ Hits        10156    10168      +12     
- Misses      17694    17697       +3     
- Partials      932      933       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@6543 6543 requested a review from a team April 15, 2026 21:16
@6543 6543 mentioned this pull request Apr 15, 2026
16 tasks
@6543 6543 changed the title Add WOODPECKER_FORCE_IGNORE_SERVICE_FAILURE option to get non breaking behavior by default Add WOODPECKER_FORCE_IGNORE_SERVICE_FAILURE option to get non breaking behavior by default Apr 15, 2026
@6543 6543 changed the title Add WOODPECKER_FORCE_IGNORE_SERVICE_FAILURE option to get non breaking behavior by default Add WOODPECKER_FORCE_IGNORE_SERVICE_FAILURE config to get non breaking behavior by default Apr 15, 2026
@6543 6543 changed the title Add WOODPECKER_FORCE_IGNORE_SERVICE_FAILURE config to get non breaking behavior by default Add WOODPECKER_FORCE_IGNORE_SERVICE_FAILURE config to preserve non breaking behavior by default Apr 15, 2026
@qwerty287

Copy link
Copy Markdown
Contributor

Docs are missing

@6543 6543 requested a review from qwerty287 April 16, 2026 09:30
@6543

6543 commented Apr 16, 2026

Copy link
Copy Markdown
Member Author

Well I added docs, still this option should not be here in the long run...

@woodpecker-bot

woodpecker-bot commented Apr 16, 2026

Copy link
Copy Markdown
Contributor

Surge PR preview deployment was removed

@6543

6543 commented Apr 17, 2026

Copy link
Copy Markdown
Member Author

@qwerty287 done

@qwerty287

Copy link
Copy Markdown
Contributor

Thanks, is it worth adding this to https://woodpecker-ci.org/migrations#user-facing-migrations?

@6543

6543 commented Apr 17, 2026

Copy link
Copy Markdown
Member Author

i would say no, this should be done when we aktually break it by that pull doing so

@6543 6543 merged commit 9505347 into woodpecker-ci:main Apr 17, 2026
6 of 7 checks passed
@6543 6543 deleted the WOODPECKER_FORCE_IGNORE_SERVICE_FAILURE branch April 17, 2026 15:10
@woodpecker-bot woodpecker-bot mentioned this pull request Apr 17, 2026
1 task
@6543 6543 added bug Something isn't working and removed enhancement improve existing features labels Apr 18, 2026
@6543 6543 changed the title Add WOODPECKER_FORCE_IGNORE_SERVICE_FAILURE config to preserve non breaking behavior by default Add WOODPECKER_FORCE_IGNORE_SERVICE_FAILURE config to preserve non-breaking behavior by default Apr 19, 2026
@woodpecker-bot woodpecker-bot mentioned this pull request Apr 27, 2026
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[v3.14.0-rc-0] When service exits with non-zero status code, the whole pipeline should not be considered failure

3 participants