Refactor server/pubsub into interface#6318
Merged
6543 merged 20 commits intoMar 30, 2026
Merged
Conversation
Contributor
|
Surge PR preview deployment was removed |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #6318 +/- ##
==========================================
+ Coverage 33.30% 33.36% +0.06%
==========================================
Files 420 421 +1
Lines 28347 28342 -5
==========================================
+ Hits 9440 9456 +16
+ Misses 18029 18007 -22
- Partials 878 879 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
anbraten
reviewed
Mar 24, 2026
Co-authored-by: Anbraten <6918444+anbraten@users.noreply.github.com>
6543
commented
Mar 24, 2026
qwerty287
reviewed
Mar 25, 2026
Member
Author
this is the coverage of just running new added @anbraten it also explizite covers the duplication test and is written in a way to just pass in new adapters asap we have them |
qwerty287
reviewed
Mar 30, 2026
Co-authored-by: qwerty287 <80460567+qwerty287@users.noreply.github.com>
qwerty287
reviewed
Mar 30, 2026
6543
commented
Mar 30, 2026
Member
Author
|
sorry last commit did belong to other pull and was reverted right away 😅 |
This was referenced Mar 30, 2026
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refactor our pubsub into an interface and now publish and listen to topics instead of label filtering.
we also now have the key const and key genaration of repo topics in the pubsub package.
also we switch from repo name to repo id for pubsub topic -> this fixes an multi-forge bug :)
part of #6317