Skip to content

Fix CLI exec with workflow matrix feature, where variables are not substituted.#6162

Merged
qwerty287 merged 4 commits into
woodpecker-ci:mainfrom
6543-forks:saces/cli-matrix
Apr 4, 2026
Merged

Fix CLI exec with workflow matrix feature, where variables are not substituted.#6162
qwerty287 merged 4 commits into
woodpecker-ci:mainfrom
6543-forks:saces/cli-matrix

Conversation

@6543

@6543 6543 commented Feb 26, 2026

Copy link
Copy Markdown
Member

woodpecker-cli exec workflow-with-matrix.yaml is broken, variables are not substituted.

this sets m.Workflow at the end resets the previous set axis data

setting m.Workflow at the end resets the previous set axis data
@6543 6543 added bug Something isn't working cli labels Feb 26, 2026
@6543

6543 commented Feb 26, 2026

Copy link
Copy Markdown
Member Author

@woodpecker-bot

woodpecker-bot commented Feb 26, 2026

Copy link
Copy Markdown
Contributor

Surge PR preview deployment was removed

@codecov

codecov Bot commented Feb 26, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 32.43%. Comparing base (9f9aa72) to head (74135f7).

Files with missing lines Patch % Lines
cli/exec/metadata.go 0.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6162      +/-   ##
==========================================
+ Coverage   32.41%   32.43%   +0.01%     
==========================================
  Files         420      420              
  Lines       28318    28318              
==========================================
+ Hits         9180     9185       +5     
+ Misses      18289    18284       -5     
  Partials      849      849              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@6543 6543 marked this pull request as ready for review April 2, 2026 17:02
@6543 6543 requested a review from a team April 2, 2026 17:02

@6543 6543 left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm from my side

@qwerty287 qwerty287 merged commit 63b75b8 into woodpecker-ci:main Apr 4, 2026
6 of 7 checks passed
@woodpecker-bot woodpecker-bot mentioned this pull request Apr 4, 2026
1 task
@6543 6543 deleted the saces/cli-matrix branch April 4, 2026 07:21
@woodpecker-bot woodpecker-bot mentioned this pull request Apr 15, 2026
1 task
@woodpecker-bot woodpecker-bot mentioned this pull request Apr 27, 2026
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working cli

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants