Skip to content

Simplify and Fix server task queue#6017

Merged
lafriks merged 15 commits into
woodpecker-ci:mainfrom
6543-forks:simplify-fix-queue
Jan 27, 2026
Merged

Simplify and Fix server task queue#6017
lafriks merged 15 commits into
woodpecker-ci:mainfrom
6543-forks:simplify-fix-queue

Conversation

@6543

@6543 6543 commented Jan 26, 2026

Copy link
Copy Markdown
Member

taken from #6011

go.woodpecker-ci.org/woodpecker/v3/server/queue/fifo.go:62:		NewMemoryQueue			100.0%
go.woodpecker-ci.org/woodpecker/v3/server/queue/fifo.go:77:		PushAtOnce			100.0%
go.woodpecker-ci.org/woodpecker/v3/server/queue/fifo.go:87:		Poll				100.0%
go.woodpecker-ci.org/woodpecker/v3/server/queue/fifo.go:114:		Done				100.0%
go.woodpecker-ci.org/woodpecker/v3/server/queue/fifo.go:119:		Error				100.0%
go.woodpecker-ci.org/woodpecker/v3/server/queue/fifo.go:125:		ErrorAtOnce			100.0%
go.woodpecker-ci.org/woodpecker/v3/server/queue/fifo.go:133:		finished			100.0%
go.woodpecker-ci.org/woodpecker/v3/server/queue/fifo.go:160:		Wait				100.0%
go.woodpecker-ci.org/woodpecker/v3/server/queue/fifo.go:175:		Extend				100.0%
go.woodpecker-ci.org/woodpecker/v3/server/queue/fifo.go:192:		Info				100.0%
go.woodpecker-ci.org/woodpecker/v3/server/queue/fifo.go:218:		Pause				100.0%
go.woodpecker-ci.org/woodpecker/v3/server/queue/fifo.go:225:		Resume				100.0%
go.woodpecker-ci.org/woodpecker/v3/server/queue/fifo.go:232:		KickAgentWorkers		100.0%
go.woodpecker-ci.org/woodpecker/v3/server/queue/fifo.go:246:		process				100.0%
go.woodpecker-ci.org/woodpecker/v3/server/queue/fifo.go:278:		filterWaiting			100.0%
go.woodpecker-ci.org/woodpecker/v3/server/queue/fifo.go:303:		assignToWorker			100.0%
go.woodpecker-ci.org/woodpecker/v3/server/queue/fifo.go:327:		resubmitExpiredPipelines	100.0%
go.woodpecker-ci.org/woodpecker/v3/server/queue/fifo.go:339:		depsInQueue			90.9%
go.woodpecker-ci.org/woodpecker/v3/server/queue/fifo.go:359:		updateDepStatusInQueue		78.6%
go.woodpecker-ci.org/woodpecker/v3/server/queue/fifo.go:388:		removeFromPendingAndWaiting	100.0%
image

@6543 6543 added bug Something isn't working server refactor delete or replace old code labels Jan 26, 2026
@codecov

codecov Bot commented Jan 26, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 78.00000% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 21.99%. Comparing base (f202470) to head (70716d3).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
server/pipeline/cancel.go 0.00% 10 Missing ⚠️
server/queue/fifo.go 97.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6017      +/-   ##
==========================================
+ Coverage   21.87%   21.99%   +0.12%     
==========================================
  Files         432      432              
  Lines       39258    39200      -58     
==========================================
+ Hits         8586     8621      +35     
+ Misses      29864    29771      -93     
  Partials      808      808              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@6543 6543 removed the wip label Jan 26, 2026
Comment thread server/pipeline/cancel.go
@lafriks

lafriks commented Jan 26, 2026

Copy link
Copy Markdown
Contributor

Lint failures

@6543

6543 commented Jan 26, 2026

Copy link
Copy Markdown
Member Author

on it

@6543 6543 requested a review from lafriks January 26, 2026 22:53
@lafriks lafriks merged commit 4edfefe into woodpecker-ci:main Jan 27, 2026
9 checks passed
@woodpecker-bot woodpecker-bot mentioned this pull request Jan 27, 2026
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working refactor delete or replace old code server

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants