Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: Use translation strings for validation messages #52496

Open
TIIUNDER opened this issue Oct 31, 2024 · 2 comments
Open

[Enhancement]: Use translation strings for validation messages #52496

TIIUNDER opened this issue Oct 31, 2024 · 2 comments
Labels
focus: checkout Issues related to checkout page. focus: i18n The issue/PR is related to internationalization. team: Rubik Store API checkout endpoints, Mini-Cart, Cart and Checkout related issues type: community contribution type: enhancement The issue is a request for an enhancement.

Comments

@TIIUNDER
Copy link

Describe the solution you'd like

The current validation error messages are some combined strings of "Please enter a valid" and the field name, for example "Please enter a valid firstname". This works for English, but not for other languages. For example in German we get "Bitte geben Sie eine gültige vorname" ein. First of all, "Vorname" needs to be capitalized, second it's "Bitte geben Sie einen gültigen Vornamen ein". So grammar, is also important.

Image

It should use translation strings from the po/mo files of WooCommerce for every single field.

Describe alternatives you've considered

No response

Additional context

No response

@TIIUNDER TIIUNDER added the type: enhancement The issue is a request for an enhancement. label Oct 31, 2024
@TIIUNDER
Copy link
Author

Same problem for "+ Add appartment, suite etc."

@TIIUNDER
Copy link
Author

And also for select dropdowns like "canton", We need "Wähle ein Kanton" and not "kanton". Also in some cases it might be "eine" or "einen" etc.

Image

@lanej0 lanej0 added focus: i18n The issue/PR is related to internationalization. focus: checkout Issues related to checkout page. team: Rubik Store API checkout endpoints, Mini-Cart, Cart and Checkout related issues labels Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
focus: checkout Issues related to checkout page. focus: i18n The issue/PR is related to internationalization. team: Rubik Store API checkout endpoints, Mini-Cart, Cart and Checkout related issues type: community contribution type: enhancement The issue is a request for an enhancement.
Projects
None yet
Development

No branches or pull requests

2 participants