This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Convert PaymentMethodErrorBoundary to Class component #12088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woocommercebot
requested review from
a team and
tarhi-saad
and removed request for
a team
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: +1.37 kB (0%) Total Size: 1.61 MB
ℹ️ View Unchanged
|
14 tasks
tarunvijwani
added
team: Rubik
focus: checkout
tarhi-saad
suggested changes
Dec 8, 2023
There was a problem hiding this comment.
Thank you, @tarunvijwani, for working on this PR! The tests are working as expected. The code mostly looks good. I left a minor suggestion below!
assets/js/blocks/cart-checkout-shared/payment-methods/payment-method-error-boundary.tsx
Outdated
Show resolved
Hide resolved
tarunvijwani
deleted the
update/10565-convert-error-broundary-method-to-class-component
branch
|
@tarunvijwani could you update the Screenshots or screencast with the final result? The image in the PR description with the after result does not reflect the changes brought in by this PR |
|
@ralucaStan We are breaking down the solution into multiple PRs. This PR is the first part of the woocommerce/woocommerce#42256, and it only fixes the existing error by converting the PaymentMethodErrorBoundary Class component to the function component. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Related woocommerce/woocommerce#42256
Why
We converted the PaymentMethodErrorBoundary Class component to the function component, and it stopped working. The issue was introduced by #9817 PR.
As per the react docs:
src: https://react.dev/reference/react/Component#catching-rendering-errors-with-an-error-boundary
In this PR, we're converting the function component to the Class component.
We will handle removing the entire express payment block if no valid express payment button exists in a different PR.
Testing Instructions
Screenshots or screencast
WooCommerce Visibility
Required:
Checklist
Required:
[type]label or a[skip-changelog]label.Conditional:
[skip-changelog]label is not present).Changelog