This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Interactivity API Collection Rating Filter #12020
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThe
This comment was automatically generated by the TypeScript Errors Report
assets/js/blocks/collection-filters/inner-blocks/rating-filter/block-wrapper.tsx
assets/js/blocks/collection-filters/inner-blocks/rating-filter/edit.tsx assets/js/blocks/collection-filters/inner-blocks/rating-filter/index.tsx |
|
Size Change: +19.8 kB (+1%) Total Size: 1.63 MB
ℹ️ View Unchanged
|
samueljseay
commented
Dec 4, 2023
|
|
||
| $selected_item = $ratings_array[0] ? array( | ||
| /* translators: %d is referring to the average rating value */ | ||
| 'label' => sprintf( __( 'Rated %d out of 5', 'woo-gutenberg-products-block' ), $ratings_array[0] ), |
There was a problem hiding this comment.
For the MVP I have not supported rendering the HTML inside the dropdown because it requires some adjustments to the dropdown to properly support it (because right now we put the whole object in context it causes issues), so for this first pass I just have a text label and I will support HTML as a follow up.
samueljseay
changed the title
samueljseay
added
the
skip-changelog
dinhtungdu
reviewed
Dec 5, 2023
There was a problem hiding this comment.
Thank you for working on this. I tested the PR and I can confirm it's working as expected. Great work!
Beside review comments, I have some suggestions:
- I think we should update the default
Collection Filtersblock template to include this new block. - In the block folder, I can see you're breaking the edit component into
edit.tsxandblock.tsxlike the current one. We don't render the block on client side now so I think we can put everything in theedit.tsxcomponent like others, what do you think?
assets/js/blocks/collection-filters/inner-blocks/rating-filter/block-wrapper.tsx
Show resolved
Hide resolved
assets/js/blocks/collection-filters/inner-blocks/rating-filter/block.json
Show resolved
Hide resolved
assets/js/blocks/collection-filters/inner-blocks/rating-filter/block.tsx
Show resolved
Hide resolved
|
Closing this as it isn't quite ready for merging and we are about to move across to the core monorepo. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What / Why
This includes:
Testing Instructions
There are 2 modes for the rating, dropdown and checkbox list. You'll need to switch and test both types.
Screenshots or screencast
WooCommerce Visibility
Required:
Checklist
Required:
[type]label or a[skip-changelog]label.Conditional:
[skip-changelog]label is not present).Changelog