This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Fix address block invalidations in the editor and address card display in Firefox #11714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woocommercebot
requested review from
a team and
nielslange
and removed request for
a team
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
packages/checkout/components/text-input/test/validated-text-input.tsx
|
|
Size Change: +338 B (0%) Total Size: 1.54 MB
ℹ️ View Unchanged
|
nielslange
approved these changes
Nov 9, 2023
There was a problem hiding this comment.
Thanks for working on this, @mikejolley. Both, the test cases you mentioned as well as edge cases I executed, worked as expected. Code-wise I could not spot anything strange. Nice work. 👏
13 tasks
|
Great work on debuggin this and fixing it on such a short time. @mikejolley I recommend creating a separate ticket with some tests for this case and working on it next, to make sure we are safe from having a regression happening again. |
tarhi-saad
pushed a commit
that referenced
this pull request
Nov 9, 2023
…y in Firefox (#11714) * Add checks to see if getCartData finished before rendering address * Prevent block error due to excessive updates of customValidation * Do not condense address in admin and handle phone field * Add missing showPhoneField for billing --------- Co-authored-by: Thomas Roberts <[email protected]>
|
Hey @mikejolley , Curious if this is going to fix the issue I am having. On the checkout page, I use autofill for everything (email, address, and CC). IF i auto populate email address, it clear the CC fields. If I auto populate the CC fields, it clears the email address field. |
|
Credit card fields? I don't think thats related to this fix. Perhaps the autocomplete entry in your browser for CC details lacks the name/email/address? If you have steps to reproduce this you could create a new ticket. I've not seen it reported anywhere else. |
nielslange
added a commit
that referenced
this pull request
Nov 13, 2023
* Empty commit for release pull request * Empty commit for release pull request * Empty commit for release pull request * Empty commit for release pull request * Update Jetpack WooCommerce Analytics module integration to check for changed template names (#11707) * Bump versions to 11.4.6 * Add testing notes * Update testing zip * Skip template related E2E tests (#11700) * Empty commit for release pull request * Fix address block invalidations in the editor and address card display in Firefox (#11714) * Add checks to see if getCartData finished before rendering address * Prevent block error due to excessive updates of customValidation * Do not condense address in admin and handle phone field * Add missing showPhoneField for billing --------- Co-authored-by: Thomas Roberts <[email protected]> * Add changelog in "readme.txt" * Run change version npm script * Add testing notes * Empty commit for release pull request * Add changelog in "readme.txt" * Add version numbers * Ensure that incompatible notices are displayed in Safari. (#11736) * Add the testing docs * Update testing notes title of 11.4.8 --------- Co-authored-by: github-actions <[email protected]> Co-authored-by: Thomas Roberts <[email protected]> Co-authored-by: Thomas Roberts <[email protected]> Co-authored-by: Saad Tarhi <[email protected]> Co-authored-by: Mike Jolley <[email protected]> Co-authored-by: Niels Lange <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR fixes some issues with the address card and address form components.
The first issue caused block invalidation due to the custom validation function changing on every render. I fixed this by implementing a ref.
Fixes #11583
The second issue only affected firefox and would cause the collapsed address component to never render. This was fixed by waiting for cart data to load before mounting.
Fixes #11650
This change also negated the need for #11062 so we should test for regressions.
The final change was to ensure the address is never collapsed in admin so form changes are visible, and to correctly hide the phone value on the frontend if that field is toggled off.
Testing Instructions
Please consider any edge cases this change may have, and also other areas of the product this may impact.
Firefox testing
WooCommerce Visibility
Required:
Checklist
Required:
[type]label or a[skip-changelog]label.Conditional:
[skip-changelog]label is not present).Changelog