This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
WIP: Run E2E test suite on WordPress 6.4 #11451
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: +411 B (0%) Total Size: 1.54 MB
ℹ️ View Unchanged
|
|
Hi @gigitux! Are we planning to merge this PR when all tests pass? Our work of fixing the failing E2E tests is still in progress. I'll need to jump on another task this week. Please let me know if I should create a separate ticket to unblock this PR! |
I think so.
If it is necessary, I will ping you! Thanks for working on this PR 🙇 |
tarhi-saad
force-pushed
the
add/e2e-tests-6.4
branch
from
286dc6b
to
da705a1
Compare
|
@gigitux, there is no block for the shop page for some reason! There should be some failing tests because of this. The 
|
|
Hey @tarhi-saad, It is expected that the shop page doesn't contain any blocks. I checked the commit da705a1 and I noticed that some E2E tests regarding the cart template are still failing.
Good catch about this! I hope that I fixed this wrong behavior with 796582d |
Aljullu
force-pushed
the
add/e2e-tests-6.4
branch
from
796582d
to
7756f85
Compare
|
@gigitux, we've created ticket woocommerce/woocommerce#42119 in response to the regression detected with WP 6.4, as discussed on Slack (p1699340273337689-slack-C8X6Q7XQU), which is also behind the failed E2E tests in the current PR. Please let us know if you need this PR merged quickly and what we can do to help move things along. |
WordPress has been released, so Since you are aware of the issue and you tracked it, I would suggest skipping the failed tests and merge this PR (if other tests don't fail) @tarhi-saad, does it make sense? |
tarhi-saad
force-pushed
the
add/e2e-tests-6.4
branch
from
254e56d
to
c4d38ae
Compare
tarhi-saad
added
skip-changelog
|
I'm closing this PR because we fixed it with #11700. However, we noticed weird behavior with E2E tests (caching issues?), @tarhi-saad will open an issue about this! |
|
Thank you for closing this PR, @gigitux!
I was doing some tests while writing the ticket for this issue, and I found out that the wp-env in trunk is now displaying the correct heading for this test: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR fixes the failing E2E tests when using WordPress 6.4
Why
Testing Instructions
Please consider any edge cases this change may have, and also other areas of the product this may impact.
Screenshots or screencast
WooCommerce Visibility
Required:
Checklist
Required:
[type]label or a[skip-changelog]label.Conditional:
[skip-changelog]label is not present).Changelog