Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Cart/Checkout: Apply btn on coupon component does not follow corner radius of other buttons #2306

Closed
garymurray opened this issue Apr 27, 2020 · 4 comments · Fixed by #2390
Closed
Assignees
Labels
focus: components Work that introduces new or updates existing components. type: bug The issue/PR concerns a confirmed bug.
Milestone

Comments

@garymurray
Copy link

Describe the bug
The Apply button on the coupon component does not follow the styling of the other buttons - it has a square radius, whereas the proceed to checkout and place order buttons are rounded.

Screenshot 2020-04-27 at 12 40 41

@nerrad nerrad added focus: components Work that introduces new or updates existing components. type: bug The issue/PR concerns a confirmed bug. labels Apr 28, 2020
@nerrad nerrad added this to the 2.6.0 milestone Apr 28, 2020
@haszari
Copy link
Member

haszari commented Apr 29, 2020

Note also the cart Proceed button is also square on front end:

Screen Shot 2020-04-29 at 3 38 46 PM

@Aljullu
Copy link
Contributor

Aljullu commented Apr 30, 2020

I'm seeing the same as @haszari. What theme were you using @garymurray?

Both of them inherit the border-radius from the theme (.button selector). The difference might come from the fact that Apply is a <button> but Proceed to Checkout is a <a>, so if a theme only styles <button> elements but not element with the class button, there might be some discrepancies in the style.

@garymurray
Copy link
Author

I was using Storefront - note the rounded corners on the place order button vs the square one on the apply button in the checkout page:

Screenshot 2020-05-01 at 10 18 12

@haszari
Copy link
Member

haszari commented May 4, 2020

In #2390 I've fixed this by removing our lone opinionated style for the place order button radius – the idea is that the theme is responsible for button roundedness, and we defer to theme.

Keen for feedback - cc @garymurray @Aljullu. Another alternative would be that we always round the cart/checkout buttons, essentially overriding the theme styles.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
focus: components Work that introduces new or updates existing components. type: bug The issue/PR concerns a confirmed bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants