Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Reviews by Product: list items have incorrect aria-label #11974

Closed
Aljullu opened this issue Nov 28, 2023 · 0 comments · Fixed by #11976
Closed

Reviews by Product: list items have incorrect aria-label #11974

Aljullu opened this issue Nov 28, 2023 · 0 comments · Fixed by #11976
Assignees
Labels
block: reviews by product Issues related to the Reviews by Product block. type: bug The issue/PR concerns a confirmed bug.

Comments

@Aljullu
Copy link
Contributor

Aljullu commented Nov 28, 2023

Blocks #11975.

To reproduce

  1. Create a post or page.
  2. Add the Reviews by Product block.
  3. Using the browser Inspector (F12), select one of the checkboxes.
  4. Notice the value of the aria-label shows placeholder signs: %1$s and %2$2.
  5. There is also an error in the console: TypeError: [sprintf] expecting number but found undefined.

imatge

Expected behavior

There should be no error and the aria-label value should show the product name and the number of reviews.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
block: reviews by product Issues related to the Reviews by Product block. type: bug The issue/PR concerns a confirmed bug.
Projects
None yet
1 participant