This repository has been archived by the owner on Jul 12, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 145
Add support for List item tags and link types #4287
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
probot-autolabeler
bot
added
tool: monorepo infrastructure
focus: components
Issues for woocommerce components
Packages
labels
May 4, 2020
psealock
approved these changes
May 6, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice thorough work here @mattsherman !
Just a couple thoughts on links, although I may be not understanding correctly here. Its also nice to see some test coverage too. I found this article really helpful and noted a few things that I learned: https://kentcdodds.com/blog/common-mistakes-with-react-testing-library
I'm pretty impressed with how well getByRole
works and how it mimics how a user or screen reader would scan a page. Just a few suggestions, but pre-approving.
Thanks for the review @psealock! I addressed all of your feedback prior to merging. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Infrastructure work in preparation for #4082 (Quick Links)
@storybook/addon-console
as a dev dependency)Link
types (wp-admin
,wc-admin
,external
)Link
componentList
item link typeonListItemClick
proplistItemTag
item propList
componentSee draft PR #4292 for a look at how these changes to
List
will be used by theQuickLinks
component in the new home screen. In particular, the item tagging and click support will be used to hook in Tracks events (not implemented yet in #4292).Screenshots
Detailed test instructions:
Storybook
Unit testing
Optional: Confidence check
List
changes haven’t affected other use ofList
inwc-admin
, such as task listChangelog Note: