Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the billing setup page from the Ads setup flow #2536

Open
2 tasks
Tracked by #2459
joemcgill opened this issue Aug 16, 2024 · 6 comments · May be fixed by #2577
Open
2 tasks
Tracked by #2459

Remove the billing setup page from the Ads setup flow #2536

joemcgill opened this issue Aug 16, 2024 · 6 comments · May be fixed by #2577
Assignees

Comments

@joemcgill
Copy link
Collaborator

joemcgill commented Aug 16, 2024

Part of #2460

When a merchant is setting up a new ads campaign from the plugin dashboard, they enter the "Set up paid campaign" flow, which includes individual steps for connecting a Google Ads account, configuring a campaign, and completing their billing setup.

image

In #2535, we are replacing the second step with the same component used during onboarding, which includes the ability to set up billing if needed. That makes the "Setup up billing" step redundant and can be removed.

Acceptance Criteria

  • The "Setup up billing" step is no longer included in the AdsStepper.
  • When billing is already set up, completing the "Create your paid campaign" step should result in the Setup Paid Ads flow being completed successfully with a new campaign.

Implementation Brief

The PR should get merged into the feature/2460-simplify-paid-ads-setup branch.

The AdsStepper component for the "Set up paid campaign" flow is in js/src/setup-ads/ads-stepper/index.js. The billing step can be removed from the array passed to the steps prop here.

The handleSubmit prop that is passed via formProps to the SetupBilling component will need to be moved to the component responsible for rendering the ads campaign setup (e.g. AdsCampaign) so that step can complete the form when finished.

For testing, billing status can be mocked using the following filter in an MU plugin:

function gla_filter_ads_billing_setup_status( $status ) {
	return 'approved';
}
add_filter( 'woocommerce_gla_ads_billing_setup_status', 'gla_filter_ads_billing_setup_status' );

Test Coverage

@joemcgill
Copy link
Collaborator Author

@eason9487 could you please review this one as well. I'd like for this to be able to be worked in parallel with #2535, if possible, so we may need some follow-up once these are merged into the target feature branch.

@eason9487
Copy link
Member

I'd like for this to be able to be worked in parallel with #2535, if possible, so we may need some follow-up once these are merged into the target feature branch.

Since it might be realized at the time of development that they need to modify more of the same files, I'm inclined to suggest doing them sequentially.

But before considering the possibility of working in parallel, maybe the doubt in #2534 (comment) needs to be clarified first as this ticket has the same situation.

@joemcgill
Copy link
Collaborator Author

But before considering the possibility of working in parallel, maybe the doubt in #2534 (comment) needs to be clarified first as this ticket has the same situation.

Agreed. I'll get that verified before moving on.

@joemcgill
Copy link
Collaborator Author

I've clarified with @fblascogarma that we'll remove this step along with the first step in #2534 and consolidate the need to set up billing to the unified campaign setup screen in #2535.

@joemcgill joemcgill removed their assignment Aug 28, 2024
@kt-12 kt-12 self-assigned this Aug 28, 2024
@kt-12 kt-12 linked a pull request Sep 4, 2024 that will close this issue
@kt-12 kt-12 assigned joemcgill and unassigned kt-12 Sep 4, 2024
@joemcgill joemcgill assigned asvinb and unassigned joemcgill Sep 5, 2024
@asvinb asvinb assigned kt-12 and unassigned asvinb Sep 6, 2024
@kt-12 kt-12 assigned asvinb and joemcgill and unassigned kt-12 Sep 7, 2024
@asvinb asvinb assigned kt-12 and unassigned asvinb and joemcgill Sep 9, 2024
@kt-12 kt-12 assigned asvinb and unassigned kt-12 Sep 11, 2024
@asvinb asvinb assigned kt-12 and unassigned asvinb Sep 12, 2024
@asvinb asvinb removed their assignment Sep 13, 2024
@kt-12 kt-12 assigned asvinb and unassigned kt-12 Sep 17, 2024
@asvinb asvinb assigned kt-12 and unassigned asvinb Sep 17, 2024
@kt-12 kt-12 assigned ankitguptaindia and unassigned kt-12 Sep 17, 2024
@kt-12 kt-12 removed their assignment Sep 20, 2024
@eason9487 eason9487 assigned kt-12 and unassigned eason9487 Sep 24, 2024
@kt-12
Copy link
Collaborator

kt-12 commented Sep 27, 2024

E2E for this task is fixed. This is good for WooCR but currently blocked by a strange error in GH action. https://github.com/woocommerce/google-listings-and-ads/actions/runs/11057375294/job/30725249745

@joemcgill joemcgill assigned eason9487 and unassigned kt-12 Sep 27, 2024
@joemcgill
Copy link
Collaborator Author

@eason9487 looks like this error has now been fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants